opendev/gerrit
Code Issues Proposed changes

Add settings screen for global edit preferences

Browse Source 
Users expect to find all preferences under the Settings menu. Account
preferences and diff preferences are already there, so add the edit
preferences too.

Similar to the diff preferences the edit preferences are rendered with
the same style as the edit preferences popup. This makes it easy for
users to see that these are actually the same settings, just accessed
through different paths.

Change-Id: I4f2c41d77a0ad43777a904155623cbe31bff284a
Signed-off-by: Edwin Kempin <ekempin@google.com>
This commit is contained in:
Edwin Kempin
2015-10-13 10:55:41 +02:00
parent 8a389c3830
commit 753169d872
8 changed files with 126 additions and 37 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
gerrit-gwtui/src/main/java/com/google/gerrit/client/Dispatcher.java
View File

@@ -29,6 +29,7 @@ import static com.google.gerrit.common.PageLinks.SETTINGS;
import static com.google.gerrit.common.PageLinks.SETTINGS_AGREEMENTS;
import static com.google.gerrit.common.PageLinks.SETTINGS_CONTACT;
import static com.google.gerrit.common.PageLinks.SETTINGS_DIFF_PREFERENCES;
import static com.google.gerrit.common.PageLinks.SETTINGS_EDIT_PREFERENCES;
import static com.google.gerrit.common.PageLinks.SETTINGS_EXTENSION;
import static com.google.gerrit.common.PageLinks.SETTINGS_GPGKEYS;
import static com.google.gerrit.common.PageLinks.SETTINGS_HTTP_PASSWORD;
@@ -43,6 +44,7 @@ import static com.google.gerrit.common.PageLinks.toChangeQuery;
import com.google.gerrit.client.account.MyAgreementsScreen;
import com.google.gerrit.client.account.MyContactInformationScreen;
import com.google.gerrit.client.account.MyDiffPreferencesScreen;
import com.google.gerrit.client.account.MyEditPreferencesScreen;
import com.google.gerrit.client.account.MyGpgKeysScreen;
import com.google.gerrit.client.account.MyGroupsScreen;
import com.google.gerrit.client.account.MyIdentitiesScreen;
@@ -533,6 +535,10 @@ public class Dispatcher {
return new MyDiffPreferencesScreen();
}
if (matchExact(SETTINGS_EDIT_PREFERENCES, token)) {
return new MyEditPreferencesScreen();
}
if (matchExact(SETTINGS_PROJECTS, token)) {
return new MyWatchedProjectsScreen();
}