From 7580853b5873ae14dad409faa9f901b331200ad5 Mon Sep 17 00:00:00 2001 From: Paladox none <thomasmulhall410@yahoo.com> Date: Wed, 31 May 2017 16:09:13 +0000 Subject: [PATCH] PolyGerrit: Fix undefined url in gr-dropdown If link.url is undefined lets return it as '' so no url is applied. Bug: Issue 6352 Change-Id: I9492e48b14e4387cbdbe87c562ffa4966323948c --- polygerrit-ui/app/elements/shared/gr-dropdown/gr-dropdown.js | 3 +++ 1 file changed, 3 insertions(+) diff --git a/polygerrit-ui/app/elements/shared/gr-dropdown/gr-dropdown.js b/polygerrit-ui/app/elements/shared/gr-dropdown/gr-dropdown.js index 42ae98beda..a034eb869d 100644 --- a/polygerrit-ui/app/elements/shared/gr-dropdown/gr-dropdown.js +++ b/polygerrit-ui/app/elements/shared/gr-dropdown/gr-dropdown.js @@ -98,6 +98,9 @@ }, _computeLinkURL(link) { + if (typeof link.url === 'undefined') { + return ''; + } if (link.target) { return link.url; }