From acdf533ca769ef96c57405e521282b5215d9863c Mon Sep 17 00:00:00 2001 From: Sasa Zivkov Date: Fri, 20 Sep 2013 14:05:15 +0200 Subject: [PATCH] Rename PluginConfigProvider to PluginConfigFactory. The PluginConfigProvider was not a guice Provider. Since all classes named like ...Provider do implement the Provider interface from guice, we can consider the naming of PluginConfigProvider as inconsistent. Change-Id: I83cbe47112865e293a7928b123d94d4b4a3839db --- Documentation/dev-plugins.txt | 4 ++-- .../{PluginConfigProvider.java => PluginConfigFactory.java} | 4 ++-- 2 files changed, 4 insertions(+), 4 deletions(-) rename gerrit-server/src/main/java/com/google/gerrit/server/config/{PluginConfigProvider.java => PluginConfigFactory.java} (90%) diff --git a/Documentation/dev-plugins.txt b/Documentation/dev-plugins.txt index c1092945f4..f1046d3a85 100644 --- a/Documentation/dev-plugins.txt +++ b/Documentation/dev-plugins.txt @@ -331,14 +331,14 @@ only use the `plugin` subsection with their own name. For example the language = Latin ---- -Via the `com.google.gerrit.server.config.PluginConfigProvider` class a +Via the `com.google.gerrit.server.config.PluginConfigFactory` class a plugin can easily access its configuration and there is no need for a plugin to parse the `gerrit.config` file on its own: [source,java] ---- @Inject - private com.google.gerrit.server.config.PluginConfigProvider cfg; + private com.google.gerrit.server.config.PluginConfigFactory cfg; ... diff --git a/gerrit-server/src/main/java/com/google/gerrit/server/config/PluginConfigProvider.java b/gerrit-server/src/main/java/com/google/gerrit/server/config/PluginConfigFactory.java similarity index 90% rename from gerrit-server/src/main/java/com/google/gerrit/server/config/PluginConfigProvider.java rename to gerrit-server/src/main/java/com/google/gerrit/server/config/PluginConfigFactory.java index a6d3c51a65..50a8f33d38 100644 --- a/gerrit-server/src/main/java/com/google/gerrit/server/config/PluginConfigProvider.java +++ b/gerrit-server/src/main/java/com/google/gerrit/server/config/PluginConfigFactory.java @@ -20,11 +20,11 @@ import com.google.inject.Singleton; import org.eclipse.jgit.lib.Config; @Singleton -public class PluginConfigProvider { +public class PluginConfigFactory { private final Config cfg; @Inject - PluginConfigProvider(@GerritServerConfig Config cfg) { + PluginConfigFactory(@GerritServerConfig Config cfg) { this.cfg = cfg; }