opendev/gerrit
Code Issues Proposed changes

ConfigUpdatedEvent: Use immutable type in field declaration

Browse Source 
Error Prone reports [1] that a field initialized to hold an immutable
collection should be declared using the immutable type itself.

[1] https://errorprone.info/bugpattern/MutableConstantField

Change-Id: I8058a45ad1c757671168ff237cecdedad04e8760
This commit is contained in:
David Pursehouse 2018-12-21 10:11:04 +09:00
parent 20fa6bd8b2
commit 7738f98c29
1 changed files with 1 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
java/com/google/gerrit/server/config/ConfigUpdatedEvent.java
View File

@ -37,7 +37,7 @@ import org.eclipse.jgit.lib.Config;
* (+ various overloaded versions of these)
*/
public class ConfigUpdatedEvent {
public static final Multimap<UpdateResult, ConfigUpdateEntry> NO_UPDATES =
public static final ImmutableMultimap<UpdateResult, ConfigUpdateEntry> NO_UPDATES =
new ImmutableMultimap.Builder<UpdateResult, ConfigUpdateEntry>().build();
private final Config oldConfig;
private final Config newConfig;