diff --git a/gerrit-gwtui/src/main/java/com/google/gerrit/client/api/ActionContext.java b/gerrit-gwtui/src/main/java/com/google/gerrit/client/api/ActionContext.java index 2b40954eec..b7307be106 100644 --- a/gerrit-gwtui/src/main/java/com/google/gerrit/client/api/ActionContext.java +++ b/gerrit-gwtui/src/main/java/com/google/gerrit/client/api/ActionContext.java @@ -114,7 +114,9 @@ public class ActionContext extends JavaScriptObject { return e.options[e.selectedIndex].text; }, - popup: function(e){this._p=@com.google.gerrit.client.api.PopupHelper::popup(Lcom/google/gerrit/client/api/ActionContext;Lcom/google/gwt/dom/client/Element;)(this,e)}, + popup: function(e){ + this._p=@com.google.gerrit.client.api.PopupHelper::popup( + Lcom/google/gerrit/client/api/ActionContext;Lcom/google/gwt/dom/client/Element;)(this,e)}, hide: function() { this._p.@com.google.gerrit.client.api.PopupHelper::hide()(); delete this['_p']; @@ -125,11 +127,18 @@ public class ActionContext extends JavaScriptObject { if (m == 'get' || m == 'delete' || i==null) this[m](b); else this[m](i,b); }, - get: function(b){@com.google.gerrit.client.api.ActionContext::get(Lcom/google/gerrit/client/rpc/RestApi;Lcom/google/gwt/core/client/JavaScriptObject;)(this._u,b)}, - post: function(i,b){@com.google.gerrit.client.api.ActionContext::post(Lcom/google/gerrit/client/rpc/RestApi;Lcom/google/gwt/core/client/JavaScriptObject;Lcom/google/gwt/core/client/JavaScriptObject;)(this._u,i,b)}, - put: function(i,b){@com.google.gerrit.client.api.ActionContext::put(Lcom/google/gerrit/client/rpc/RestApi;Lcom/google/gwt/core/client/JavaScriptObject;Lcom/google/gwt/core/client/JavaScriptObject;)(this._u,i,b)}, - 'delete': function(b){@com.google.gerrit.client.api.ActionContext::delete(Lcom/google/gerrit/client/rpc/RestApi;Lcom/google/gwt/core/client/JavaScriptObject;)(this._u,b)}, - del: function(b){@com.google.gerrit.client.api.ActionContext::delete(Lcom/google/gerrit/client/rpc/RestApi;Lcom/google/gwt/core/client/JavaScriptObject;)(this._u,b)}, + get: function(b){@com.google.gerrit.client.api.ActionContext::get( + Lcom/google/gerrit/client/rpc/RestApi;Lcom/google/gwt/core/client/JavaScriptObject;)(this._u,b)}, + post: function(i,b){@com.google.gerrit.client.api.ActionContext::post( + Lcom/google/gerrit/client/rpc/RestApi;Lcom/google/gwt/core/client/JavaScriptObject;Lcom/google/gwt/core/client/JavaScriptObject;)( + this._u,i,b)}, + put: function(i,b){@com.google.gerrit.client.api.ActionContext::put( + Lcom/google/gerrit/client/rpc/RestApi;Lcom/google/gwt/core/client/JavaScriptObject;Lcom/google/gwt/core/client/JavaScriptObject;)( + this._u,i,b)}, + 'delete': function(b){@com.google.gerrit.client.api.ActionContext::delete( + Lcom/google/gerrit/client/rpc/RestApi;Lcom/google/gwt/core/client/JavaScriptObject;)(this._u,b)}, + del: function(b){@com.google.gerrit.client.api.ActionContext::delete( + Lcom/google/gerrit/client/rpc/RestApi;Lcom/google/gwt/core/client/JavaScriptObject;)(this._u,b)}, }; }-*/; diff --git a/gerrit-gwtui/src/main/java/com/google/gerrit/client/api/Plugin.java b/gerrit-gwtui/src/main/java/com/google/gerrit/client/api/Plugin.java index 931a04de10..6acb420b56 100644 --- a/gerrit-gwtui/src/main/java/com/google/gerrit/client/api/Plugin.java +++ b/gerrit-gwtui/src/main/java/com/google/gerrit/client/api/Plugin.java @@ -61,11 +61,18 @@ final class Plugin extends JavaScriptObject { screen: function(p,c){G._screen(this.name,p,c)}, url: function (u){return G.url(this._url(u))}, - get: function(u,b){@com.google.gerrit.client.api.ActionContext::get(Lcom/google/gerrit/client/rpc/RestApi;Lcom/google/gwt/core/client/JavaScriptObject;)(this._api(u),b)}, - post: function(u,i,b){@com.google.gerrit.client.api.ActionContext::post(Lcom/google/gerrit/client/rpc/RestApi;Lcom/google/gwt/core/client/JavaScriptObject;Lcom/google/gwt/core/client/JavaScriptObject;)(this._api(u),i,b)}, - put: function(u,i,b){@com.google.gerrit.client.api.ActionContext::put(Lcom/google/gerrit/client/rpc/RestApi;Lcom/google/gwt/core/client/JavaScriptObject;Lcom/google/gwt/core/client/JavaScriptObject;)(this._api(u),i,b)}, - 'delete': function(u,b){@com.google.gerrit.client.api.ActionContext::delete(Lcom/google/gerrit/client/rpc/RestApi;Lcom/google/gwt/core/client/JavaScriptObject;)(this._api(u),b)}, - del: function(u,b){@com.google.gerrit.client.api.ActionContext::delete(Lcom/google/gerrit/client/rpc/RestApi;Lcom/google/gwt/core/client/JavaScriptObject;)(this._api(u),b)}, + get: function(u,b){@com.google.gerrit.client.api.ActionContext::get( + Lcom/google/gerrit/client/rpc/RestApi;Lcom/google/gwt/core/client/JavaScriptObject;)(this._api(u),b)}, + post: function(u,i,b){@com.google.gerrit.client.api.ActionContext::post( + Lcom/google/gerrit/client/rpc/RestApi;Lcom/google/gwt/core/client/JavaScriptObject;Lcom/google/gwt/core/client/JavaScriptObject;)( + this._api(u),i,b)}, + put: function(u,i,b){@com.google.gerrit.client.api.ActionContext::put( + Lcom/google/gerrit/client/rpc/RestApi;Lcom/google/gwt/core/client/JavaScriptObject;Lcom/google/gwt/core/client/JavaScriptObject;)( + this._api(u),i,b)}, + 'delete': function(u,b){@com.google.gerrit.client.api.ActionContext::delete( + Lcom/google/gerrit/client/rpc/RestApi;Lcom/google/gwt/core/client/JavaScriptObject;)(this._api(u),b)}, + del: function(u,b){@com.google.gerrit.client.api.ActionContext::delete( + Lcom/google/gerrit/client/rpc/RestApi;Lcom/google/gwt/core/client/JavaScriptObject;)(this._api(u),b)}, _loadedGwt: function(){@com.google.gerrit.client.api.PluginLoader::loaded()()}, _api: function(u){return @com.google.gerrit.client.rpc.RestApi::new(Ljava/lang/String;)(this._url(u))}, diff --git a/gerrit-gwtui/src/main/java/com/google/gerrit/client/change/RelatedChangesTab.java b/gerrit-gwtui/src/main/java/com/google/gerrit/client/change/RelatedChangesTab.java index 96d0d1095a..8277de6e05 100644 --- a/gerrit-gwtui/src/main/java/com/google/gerrit/client/change/RelatedChangesTab.java +++ b/gerrit-gwtui/src/main/java/com/google/gerrit/client/change/RelatedChangesTab.java @@ -68,7 +68,8 @@ class RelatedChangesTab implements IsWidget { AbstractImagePrototype.create(Gerrit.RESOURCES.arrowRight()).getSafeHtml(); private static final native String init(String o) /*-{ - $wnd[o] = $entry(@com.google.gerrit.client.change.RelatedChangesTab::onOpen(Lcom/google/gwt/dom/client/NativeEvent;Lcom/google/gwt/dom/client/Element;)); + $wnd[o] = $entry(@com.google.gerrit.client.change.RelatedChangesTab::onOpen( + Lcom/google/gwt/dom/client/NativeEvent;Lcom/google/gwt/dom/client/Element;)); return o + '(event,this)'; }-*/; diff --git a/gerrit-httpd/src/main/java/com/google/gerrit/httpd/restapi/RestApiServlet.java b/gerrit-httpd/src/main/java/com/google/gerrit/httpd/restapi/RestApiServlet.java index a4a6d39d02..dca850acc5 100644 --- a/gerrit-httpd/src/main/java/com/google/gerrit/httpd/restapi/RestApiServlet.java +++ b/gerrit-httpd/src/main/java/com/google/gerrit/httpd/restapi/RestApiServlet.java @@ -960,7 +960,8 @@ public class RestApiServlet extends HttpServlet { if (user instanceof AnonymousUser) { throw new AuthException("Authentication required"); } else if (!globals.webSession.get().isAccessPathOk(AccessPath.REST_API)) { - throw new AuthException("Invalid authentication method. In order to authenticate, prefix the REST endpoint URL with /a/ (e.g. http://example.com/a/projects/)."); + throw new AuthException("Invalid authentication method. In order to authenticate, " + + "prefix the REST endpoint URL with /a/ (e.g. http://example.com/a/projects/)."); } } user.setAccessPath(AccessPath.REST_API); diff --git a/gerrit-sshd/src/main/java/com/google/gerrit/sshd/commands/CreateProjectCommand.java b/gerrit-sshd/src/main/java/com/google/gerrit/sshd/commands/CreateProjectCommand.java index b93eb75a7e..7dc558ee4e 100644 --- a/gerrit-sshd/src/main/java/com/google/gerrit/sshd/commands/CreateProjectCommand.java +++ b/gerrit-sshd/src/main/java/com/google/gerrit/sshd/commands/CreateProjectCommand.java @@ -109,7 +109,8 @@ final class CreateProjectCommand extends SshCommand { requireChangeID = InheritableBoolean.TRUE; } - @Option(name = "--create-new-change-for-all-not-in-target", aliases = {"--ncfa"}, usage = "if a new change will be created for every commit not in target branch") + @Option(name = "--create-new-change-for-all-not-in-target", aliases = {"--ncfa"}, + usage = "if a new change will be created for every commit not in target branch") void setNewChangeForAllNotInTarget(@SuppressWarnings("unused") boolean on) { createNewChangeForAllNotInTarget = InheritableBoolean.TRUE; } @@ -124,7 +125,8 @@ final class CreateProjectCommand extends SshCommand { @Option(name = "--max-object-size-limit", usage = "max Git object size for this project") private String maxObjectSizeLimit; - @Option(name = "--plugin-config", usage = "plugin configuration parameter with format '.='") + @Option(name = "--plugin-config", + usage = "plugin configuration parameter with format '.='") private List pluginConfigValues; private String projectName; diff --git a/gerrit-sshd/src/main/java/com/google/gerrit/sshd/commands/ReviewCommand.java b/gerrit-sshd/src/main/java/com/google/gerrit/sshd/commands/ReviewCommand.java index 3ac72a7dc6..bc820a4bc7 100644 --- a/gerrit-sshd/src/main/java/com/google/gerrit/sshd/commands/ReviewCommand.java +++ b/gerrit-sshd/src/main/java/com/google/gerrit/sshd/commands/ReviewCommand.java @@ -73,7 +73,9 @@ public class ReviewCommand extends SshCommand { private final Set patchSets = new HashSet<>(); - @Argument(index = 0, required = true, multiValued = true, metaVar = "{COMMIT | CHANGE,PATCHSET}", usage = "list of commits or patch sets to review") + @Argument(index = 0, required = true, multiValued = true, + metaVar = "{COMMIT | CHANGE,PATCHSET}", + usage = "list of commits or patch sets to review") void addPatchSetId(final String token) { try { PatchSet ps = CommandUtils.parsePatchSet(token, db, projectControl, diff --git a/gerrit-util-http/src/main/java/com/google/gerrit/util/http/RequestUtil.java b/gerrit-util-http/src/main/java/com/google/gerrit/util/http/RequestUtil.java index 922a8d5649..888ad2f126 100644 --- a/gerrit-util-http/src/main/java/com/google/gerrit/util/http/RequestUtil.java +++ b/gerrit-util-http/src/main/java/com/google/gerrit/util/http/RequestUtil.java @@ -35,6 +35,7 @@ public class RequestUtil { * without decoding URL-encoded characters. */ public static String getEncodedPathInfo(HttpServletRequest req) { + // CS IGNORE LineLength FOR NEXT 3 LINES. REASON: URL. // Based on com.google.guice.ServletDefinition$1#getPathInfo() from: // https://github.com/google/guice/blob/41c126f99d6309886a0ded2ac729033d755e1593/extensions/servlet/src/com/google/inject/servlet/ServletDefinition.java String servletPath = req.getServletPath(); diff --git a/plugins/commit-message-length-validator b/plugins/commit-message-length-validator index cee1dcd7bd..ecec6dfe7e 160000 --- a/plugins/commit-message-length-validator +++ b/plugins/commit-message-length-validator @@ -1 +1 @@ -Subproject commit cee1dcd7bdfaa82e2e72ebc382ec13c393892125 +Subproject commit ecec6dfe7ed67431d96acf9dabac3885463900e8 diff --git a/tools/checkstyle.xml b/tools/checkstyle.xml index a9f8cfef83..d887bb2aca 100644 --- a/tools/checkstyle.xml +++ b/tools/checkstyle.xml @@ -14,10 +14,12 @@ edited to remove noisy warnings. + - + + @@ -27,9 +29,8 @@ edited to remove noisy warnings. - + - @@ -100,4 +101,9 @@ edited to remove noisy warnings. + + + + +