opendev/gerrit
Code Issues Proposed changes

Fix: Comment notification mail is not sent to project watchers

Browse Source 
If a user has NotifyType.NEW_CHANGES, but not NotifyType.ALL_COMMENTS, on
project A, and has NotifyType.ALL_COMMENTS on the special "All-Projects"
project, then he will not receive any notification emails for comments on
project A.

Change-Id: I91cc1e1ebc3692265e5554ed63cab7a47dc0253e
This commit is contained in:
Yang Zhenhui
2013-01-09 15:35:13 +08:00
committed by David Pursehouse
parent c4cd304fe3
commit 77d0b8bbae
1 changed files with 1 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
gerrit-server/src/main/java/com/google/gerrit/server/mail/ChangeEmail.java
View File

@@ -361,8 +361,8 @@ public abstract class ChangeEmail extends NotificationEmail {
for (AccountProjectWatch w : args.db.get().accountProjectWatches()
.byProject(change.getProject())) {
projectWatchers.add(w.getAccountId());
if (w.isNotify(type)) {
projectWatchers.add(w.getAccountId());
add(matching, w);
}
}