opendev/gerrit
Code Issues Proposed changes

Enable Keyboard navigation after change has been submitted / abandoned / restored

Browse Source 
Ensure that the keyboard navigation is enabled in
the change screen after a change has been
submitted, abandoned or restored.

When a change is submitted, abandoned or restored
the change screen is updated without reloading the
complete page. In this case the key navigation got
disabled.

Bug: issue 498
Change-Id: Ia9e2bc039584a60c540950610e65c9fb31c1a09f
Signed-off-by: Edwin Kempin <edwin.kempin@gmail.com>
This commit is contained in:
Edwin Kempin
2010-07-15 09:30:20 +02:00
parent f7e03ee787
commit 7836893350
2 changed files with 14 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files

13
gerrit-gwtui/src/main/java/com/google/gerrit/client/changes/ChangeScreen.java
View File

@@ -115,7 +115,6 @@ public class ChangeScreen extends Screen {
super.registerKeys(); super.registerKeys();
regNavigation = GlobalKey.add(this, keysNavigation); regNavigation = GlobalKey.add(this, keysNavigation);
regAction = GlobalKey.add(this, keysAction); regAction = GlobalKey.add(this, keysAction);
patchSetsBlock.setRegisterKeys(true);
} }
public void refresh() { public void refresh() {
@@ -125,6 +124,11 @@ public class ChangeScreen extends Screen {
protected void preDisplay(final ChangeDetail r) { protected void preDisplay(final ChangeDetail r) {
display(r); display(r);
} }
@Override
protected void postDisplay() {
patchSetsBlock.setRegisterKeys(true);
}
}); });
} }
@@ -217,7 +221,12 @@ public class ChangeScreen extends Screen {
setPageTitle(titleBuf.toString()); setPageTitle(titleBuf.toString());
} }
void display(final ChangeDetail detail) { void update(final ChangeDetail detail) {
display(detail);
patchSetsBlock.setRegisterKeys(true);
}
private void display(final ChangeDetail detail) {
displayTitle(detail.getChange().getKey(), detail.getChange().getSubject()); displayTitle(detail.getChange().getKey(), detail.getChange().getSubject());
if (starChange != null) { if (starChange != null) {

6
gerrit-gwtui/src/main/java/com/google/gerrit/client/changes/PatchSetComplexDisclosurePanel.java
View File

@@ -405,7 +405,7 @@ class PatchSetComplexDisclosurePanel extends ComplexDisclosurePanel implements O
new AbandonChangeDialog(patchSet.getId(), new AbandonChangeDialog(patchSet.getId(),
new AsyncCallback<ChangeDetail>() { new AsyncCallback<ChangeDetail>() {
public void onSuccess(ChangeDetail result) { public void onSuccess(ChangeDetail result) {
changeScreen.display(result); changeScreen.update(result);
} }
public void onFailure(Throwable caught) { public void onFailure(Throwable caught) {
@@ -425,7 +425,7 @@ class PatchSetComplexDisclosurePanel extends ComplexDisclosurePanel implements O
new RestoreChangeDialog(patchSet.getId(), new RestoreChangeDialog(patchSet.getId(),
new AsyncCallback<ChangeDetail>() { new AsyncCallback<ChangeDetail>() {
public void onSuccess(ChangeDetail result) { public void onSuccess(ChangeDetail result) {
changeScreen.display(result); changeScreen.update(result);
} }
public void onFailure(Throwable caught) { public void onFailure(Throwable caught) {
@@ -516,7 +516,7 @@ class PatchSetComplexDisclosurePanel extends ComplexDisclosurePanel implements O
new SubmitFailureDialog(result, msg).center(); new SubmitFailureDialog(result, msg).center();
} }
} }
changeScreen.display(result); changeScreen.update(result);
} }
public PatchSet getPatchSet() { public PatchSet getPatchSet() {