Merge "Remove 'send email' checkbox from reply box on change screen" into stable-2.9
This commit is contained in:
Binary file not shown.
|
Before Width: | Height: | Size: 55 KiB After Width: | Height: | Size: 54 KiB |
@@ -601,11 +601,6 @@ comment needs to be edited.
|
||||
|
||||
The `Post` button publishes the comments and the votes.
|
||||
|
||||
The `send email` checkbox controls whether the reply should trigger
|
||||
email notifications for other users. Deselecting the checkbox means
|
||||
that there will be no email notification about the change update to the
|
||||
change author, the reviewers or any other user.
|
||||
|
||||
image::images/user-review-ui-change-screen-replying.png[width=800, link="images/user-review-ui-change-screen-replying.png"]
|
||||
|
||||
If a user can approve a label that is still required, a quick approve
|
||||
|
||||
@@ -99,7 +99,6 @@ class ReplyBox extends Composite {
|
||||
@UiField Element labelsParent;
|
||||
@UiField Grid labelsTable;
|
||||
@UiField Button post;
|
||||
@UiField CheckBox email;
|
||||
@UiField Button cancel;
|
||||
@UiField ScrollPanel commentsPanel;
|
||||
@UiField FlowPanel comments;
|
||||
@@ -188,15 +187,6 @@ class ReplyBox extends Composite {
|
||||
}
|
||||
}
|
||||
|
||||
@UiHandler("email")
|
||||
void onEmail(ValueChangeEvent<Boolean> e) {
|
||||
if (e.getValue()) {
|
||||
in.notify(ReviewInput.NotifyHandling.ALL);
|
||||
} else {
|
||||
in.notify(ReviewInput.NotifyHandling.NONE);
|
||||
}
|
||||
}
|
||||
|
||||
@UiHandler("post")
|
||||
void onPost(ClickEvent e) {
|
||||
in.message(getMessage());
|
||||
|
||||
@@ -68,7 +68,7 @@ limitations under the License.
|
||||
styleName='{res.style.button}'>
|
||||
<ui:attribute name='title'/>
|
||||
<div>Post</div>
|
||||
</g:Button> and <g:CheckBox ui:field='email' value='true'>send email</g:CheckBox></ui:msg>
|
||||
</g:Button></ui:msg>
|
||||
|
||||
<g:Button ui:field='cancel'
|
||||
title='Close reply form (Shortcut: Esc)'
|
||||
|
||||
Reference in New Issue
Block a user