opendev/gerrit
Code Issues Proposed changes

Revert: Use BooleanCondition for #setVisible

Browse Source 
Change-Id: I81a4b5f1c062d14423e1e3364d10f35810bb8b80
This commit is contained in:
Patrick Hiesel
2017-08-16 17:56:34 +02:00
parent e1a664869c
commit 7890f85bed
1 changed files with 4 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
gerrit-server/src/main/java/com/google/gerrit/server/change/Revert.java
View File

@@ -14,6 +14,7 @@
package com.google.gerrit.server.change; package com.google.gerrit.server.change;
import static com.google.gerrit.extensions.conditions.BooleanCondition.and;
import static com.google.gerrit.server.permissions.RefPermission.CREATE_CHANGE; import static com.google.gerrit.server.permissions.RefPermission.CREATE_CHANGE;
import com.google.common.base.Strings; import com.google.common.base.Strings;
@@ -240,8 +241,9 @@ public class Revert extends RetryingRestModifyView<ChangeResource, RevertInput,
.setLabel("Revert") .setLabel("Revert")
.setTitle("Revert the change") .setTitle("Revert the change")
.setVisible( .setVisible(
change.getStatus() == Change.Status.MERGED and(
&& permissionBackend.user(user).ref(change.getDest()).testOrFalse(CREATE_CHANGE)); change.getStatus() == Change.Status.MERGED,
permissionBackend.user(user).ref(change.getDest()).testCond(CREATE_CHANGE)));
} }
private class NotifyOp implements BatchUpdateOp { private class NotifyOp implements BatchUpdateOp {