opendev/gerrit
Code Issues Proposed changes

Abstract PolyGerrit router

Browse Source 
Set up the mechanism for generating URLs and triggering navigation in PG
components in a way that is decoupled from page.js and gr-router.
Upgrade some components to use this system.

Feature: Issue 6446
Change-Id: Idc18cbd87b8e4e05d24ae6a5feb0a0a43f47fd7f
This commit is contained in:
Wyatt Allen
2017-06-08 09:20:46 -07:00
parent a29772693b
commit 797480f4fc
17 changed files with 315 additions and 53 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
polygerrit-ui/app/test/common-test-setup.html
View File

@@ -15,5 +15,5 @@ See the License for the specific language governing permissions and
limitations under the License.
-->
<link rel="import"
href="../bower_components/iron-test-helpers/iron-test-helpers.html" />
<link rel="import" href="../bower_components/iron-test-helpers/iron-test-helpers.html" />
<link rel="import" href="test-router.html" />

1
polygerrit-ui/app/test/index.html
View File

@@ -62,6 +62,7 @@ limitations under the License.
'core/gr-account-dropdown/gr-account-dropdown_test.html',
'core/gr-error-manager/gr-error-manager_test.html',
'core/gr-main-header/gr-main-header_test.html',
'core/gr-router/gr-router_test.html',
'core/gr-reporting/gr-reporting_test.html',
'core/gr-search-bar/gr-search-bar_test.html',
'diff/gr-diff-builder/gr-diff-builder_test.html',

21
polygerrit-ui/app/test/test-router.html Normal file
View File

@@ -0,0 +1,21 @@
<!DOCTYPE html>
<!--
Copyright (C) 2017 The Android Open Source Project
Licensed under the Apache License, Version 2.0 (the "License");
you may not use this file except in compliance with the License.
You may obtain a copy of the License at
http://www.apache.org/licenses/LICENSE-2.0
Unless required by applicable law or agreed to in writing, software
distributed under the License is distributed on an "AS IS" BASIS,
WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
See the License for the specific language governing permissions and
limitations under the License.
-->
<link rel="import" href="../elements/core/gr-navigation/gr-navigation.html">
<script>
Gerrit.Nav.setup(url => { /* noop */ }, params => '');
</script>