opendev/gerrit
Code Issues Proposed changes

Correctly annotate SshInfo parameter in CommitValidators constructor

Browse Source 
SshInfo should be annotated with @Assisted as described in the Guice
documentation [1], and according to the current coding conventions used
in Gerrit.

[1] https://code.google.com/p/google-guice/wiki/AssistedInject

Change-Id: I76dc643318fed6845341865c66290caed9c550c1
This commit is contained in:
Gustaf Lundh
2013-01-08 15:49:24 +01:00
committed by David Pursehouse
parent 55456d0578
commit 7a63bf2528
1 changed files with 1 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
gerrit-server/src/main/java/com/google/gerrit/server/git/validators/CommitValidators.java
View File

@@ -74,9 +74,9 @@ public class CommitValidators {
@Inject @Inject
CommitValidators(@GerritPersonIdent final PersonIdent gerritIdent, CommitValidators(@GerritPersonIdent final PersonIdent gerritIdent,
final SshInfo sshInfo,
@CanonicalWebUrl @Nullable final String canonicalWebUrl, @CanonicalWebUrl @Nullable final String canonicalWebUrl,
final DynamicSet<CommitValidationListener> commitValidationListeners, final DynamicSet<CommitValidationListener> commitValidationListeners,
@Assisted final SshInfo sshInfo,
@Assisted final Repository repo, @Assisted final RefControl refControl) { @Assisted final Repository repo, @Assisted final RefControl refControl) {
this.gerritIdent = gerritIdent; this.gerritIdent = gerritIdent;
this.refControl = refControl; this.refControl = refControl;