Correctly annotate SshInfo parameter in CommitValidators constructor
SshInfo should be annotated with @Assisted as described in the Guice documentation [1], and according to the current coding conventions used in Gerrit. [1] https://code.google.com/p/google-guice/wiki/AssistedInject Change-Id: I76dc643318fed6845341865c66290caed9c550c1
This commit is contained in:
committed by
David Pursehouse
parent
55456d0578
commit
7a63bf2528
@@ -74,9 +74,9 @@ public class CommitValidators {
|
||||
|
||||
@Inject
|
||||
CommitValidators(@GerritPersonIdent final PersonIdent gerritIdent,
|
||||
final SshInfo sshInfo,
|
||||
@CanonicalWebUrl @Nullable final String canonicalWebUrl,
|
||||
final DynamicSet<CommitValidationListener> commitValidationListeners,
|
||||
@Assisted final SshInfo sshInfo,
|
||||
@Assisted final Repository repo, @Assisted final RefControl refControl) {
|
||||
this.gerritIdent = gerritIdent;
|
||||
this.refControl = refControl;
|
||||
|
||||
Reference in New Issue
Block a user