opendev/gerrit
Code Issues Proposed changes

AccountAccess: Remove unused methods

Browse Source 
The database indexes that were only needed to support these methods are
deleted.

Change-Id: Iefc47c2dbe404453636d347c4fc2f3bc9a5c1cd4
Signed-off-by: Edwin Kempin <ekempin@google.com>
This commit is contained in:
Edwin Kempin
2017-03-10 14:35:58 +01:00
parent f36b3d7a75
commit 7a8022c764
6 changed files with 45 additions and 27 deletions
Download Patch File Download Diff File Expand all files Collapse all files

10
gerrit-reviewdb/src/main/java/com/google/gerrit/reviewdb/server/AccountAccess.java
View File

@@ -31,16 +31,6 @@ public interface AccountAccess extends Access<Account, Account.Id> {
@Query("WHERE preferredEmail = ? LIMIT 2")
ResultSet<Account> byPreferredEmail(String email) throws OrmException;
@Query("WHERE fullName = ? LIMIT 2")
ResultSet<Account> byFullName(String name) throws OrmException;
@Query("WHERE fullName >= ? AND fullName <= ? ORDER BY fullName LIMIT ?")
ResultSet<Account> suggestByFullName(String nameA, String nameB, int limit) throws OrmException;
@Query("WHERE preferredEmail >= ? AND preferredEmail <= ? ORDER BY preferredEmail LIMIT ?")
ResultSet<Account> suggestByPreferredEmail(String nameA, String nameB, int limit)
throws OrmException;
@Query("ORDER BY accountId")
ResultSet<Account> all() throws OrmException;
}

6
gerrit-reviewdb/src/main/resources/com/google/gerrit/reviewdb/server/index_generic.sql
View File

@@ -6,14 +6,10 @@
-- *********************************************************************
-- AccountAccess
-- covers: byPreferredEmail, suggestByPreferredEmail
-- covers: byPreferredEmail
CREATE INDEX accounts_byPreferredEmail
ON accounts (preferred_email);
-- covers: suggestByFullName
CREATE INDEX accounts_byFullName
ON accounts (full_name);
-- *********************************************************************
-- AccountGroupMemberAccess

7
gerrit-reviewdb/src/main/resources/com/google/gerrit/reviewdb/server/index_maxdb.sql
View File

@@ -7,16 +7,11 @@ delimiter #
-- *********************************************************************
-- AccountAccess
-- covers: byPreferredEmail, suggestByPreferredEmail
-- covers: byPreferredEmail
CREATE INDEX accounts_byPreferredEmail
ON accounts (preferred_email)
#
-- covers: suggestByFullName
CREATE INDEX accounts_byFullName
ON accounts (full_name)
#
-- *********************************************************************
-- AccountGroupMemberAccess

6
gerrit-reviewdb/src/main/resources/com/google/gerrit/reviewdb/server/index_postgres.sql
View File

@@ -53,14 +53,10 @@ delimiter ;
-- *********************************************************************
-- AccountAccess
-- covers: byPreferredEmail, suggestByPreferredEmail
-- covers: byPreferredEmail
CREATE INDEX accounts_byPreferredEmail
ON accounts (preferred_email);
-- covers: suggestByFullName
CREATE INDEX accounts_byFullName
ON accounts (full_name);
-- *********************************************************************
-- AccountGroupMemberAccess