Revert "Perform user.getEffectiveGroups() less eagerly"
This reverts commit f7569d0cb2.
The implementation removes any ability for slow GroupBackends
to perform their own per-request group level caching.
The correct way to do less eager lookups is for the LDAP
implementation of GroupBackend to create an emtpy membership
and then populate it on demand as requests arrive and need
to be looked up in the contains() methods.
Change-Id: I65210b24bffe10c5b158668867c8167c84712d17
			
			
This commit is contained in:
		| @@ -14,14 +14,12 @@ | ||||
|  | ||||
| package com.google.gerrit.server; | ||||
|  | ||||
| import com.google.gerrit.reviewdb.client.AccountGroup; | ||||
| import com.google.gerrit.reviewdb.client.AccountProjectWatch; | ||||
| import com.google.gerrit.reviewdb.client.Change; | ||||
| import com.google.gerrit.server.account.CapabilityControl; | ||||
| import com.google.gerrit.server.account.GroupMembership; | ||||
| import com.google.inject.servlet.RequestScoped; | ||||
|  | ||||
| import java.util.Arrays; | ||||
| import java.util.Collection; | ||||
| import java.util.Set; | ||||
|  | ||||
| @@ -79,14 +77,6 @@ public abstract class CurrentUser { | ||||
|    */ | ||||
|   public abstract GroupMembership getEffectiveGroups(); | ||||
|  | ||||
|   public boolean memberOfAny(Iterable<AccountGroup.UUID> ids) { | ||||
|     return getEffectiveGroups().containsAnyOf(ids); | ||||
|   } | ||||
|  | ||||
|   public boolean memberOf(AccountGroup.UUID id) { | ||||
|     return memberOfAny(Arrays.asList(id)); | ||||
|   } | ||||
|  | ||||
|   /** Set of changes starred by this user. */ | ||||
|   public abstract Set<Change.Id> getStarredChanges(); | ||||
|  | ||||
|   | ||||
		Reference in New Issue
	
	Block a user
	 Shawn Pearce
					Shawn Pearce