opendev/gerrit
Code Issues Proposed changes

ChangeRebuilderImpl: Don't execute passed-in update manager

Browse Source 
When the caller has a NoteDbUpdateManager to pass in, they are
responsible for the lifecycle of that object.

Change-Id: I2a7830a0a0054ce175cd9599b7731744c8e3cd68
This commit is contained in:
Dave Borowitz
2016-04-07 14:55:09 -04:00
parent 720cf6e28e
commit 7ae25336f6
1 changed files with 1 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
gerrit-server/src/main/java/com/google/gerrit/server/notedb/ChangeRebuilderImpl.java
View File

@@ -172,10 +172,8 @@ public class ChangeRebuilderImpl extends ChangeRebuilder {
OrmException, ConfigInvalidException {
Change change = new Change(bundle.getChange());
buildUpdates(manager, bundle);
NoteDbChangeState newState = NoteDbChangeState.applyDelta(
return NoteDbChangeState.applyDelta(
change, manager.stage().get(change.getId()));
manager.execute();
return newState;
}
private void buildUpdates(NoteDbUpdateManager manager, ChangeBundle bundle)