Added gwt-test-utils to test EditIterator.

Modfied lib/maven.defs so that maven_jar() is able to handle snapshot
builds.

Simplified the implementation of the advance() method in
EditIterator. Previously, the method was calling substring()
on the lines, which was unnecessary.

Change-Id: I3b00caa140539ae77605721d741afae75ae1448e

gerrit-gwtui/src/test/java/com/google/gerrit/client/diff/EditIteratorTest.java

@@ -0,0 +1,97 @@
+// Copyright (C) 2013 The Android Open Source Project
+//
+// Licensed under the Apache License, Version 2.0 (the "License");
+// you may not use this file except in compliance with the License.
+// You may obtain a copy of the License at
+//
+// http://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing, software
+// distributed under the License is distributed on an "AS IS" BASIS,
+// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+// See the License for the specific language governing permissions and
+// limitations under the License.
+
+package com.google.gerrit.client.diff;
+
+import static org.junit.Assert.assertEquals;
+
+import com.google.gerrit.client.diff.CodeMirrorDemo.EditIterator;
+import com.google.gwt.core.client.JavaScriptObject;
+import com.google.gwt.core.client.JsArrayString;
+
+import com.googlecode.gwt.test.GwtModule;
+import com.googlecode.gwt.test.GwtTest;
+
+import net.codemirror.lib.LineCharacter;
+
+import org.junit.Before;
+import org.junit.Test;
+
+/** Unit tests for EditIterator */
+@GwtModule("com.google.gerrit.GerritGwtUI")
+public class EditIteratorTest extends GwtTest {
+  private JsArrayString lines;
+
+  private void assertLineChsEqual(LineCharacter a, LineCharacter b) {
+    assertEquals(a.getLine() + "," + a.getCh(), b.getLine() + "," + b.getCh());
+  }
+
+  @Before
+  public void initialize() {
+    lines = (JsArrayString) JavaScriptObject.createArray();
+    lines.push("1st");
+    lines.push("2nd");
+    lines.push("3rd");
+  }
+
+  @Test
+  public void testNoAdvance() {
+    EditIterator iter = new EditIterator(lines, 0);
+    assertLineChsEqual(LineCharacter.create(0, 0), iter.advance(0));
+  }
+
+  @Test
+  public void testSimpleAdvance() {
+    EditIterator iter = new EditIterator(lines, 0);
+    assertLineChsEqual(LineCharacter.create(0, 1), iter.advance(1));
+  }
+
+  @Test
+  public void testEndsBeforeNewline() {
+    EditIterator iter = new EditIterator(lines, 0);
+    assertLineChsEqual(LineCharacter.create(0, 3), iter.advance(3));
+  }
+
+  @Test
+  public void testEndsOnNewline() {
+    EditIterator iter = new EditIterator(lines, 0);
+    assertLineChsEqual(LineCharacter.create(1, 0), iter.advance(4));
+  }
+
+  @Test
+  public void testAcrossNewline() {
+    EditIterator iter = new EditIterator(lines, 0);
+    assertLineChsEqual(LineCharacter.create(1, 1), iter.advance(5));
+  }
+
+  @Test
+  public void testContinueFromBeforeNewline() {
+    EditIterator iter = new EditIterator(lines, 0);
+    iter.advance(3);
+    assertLineChsEqual(LineCharacter.create(2, 2), iter.advance(7));
+  }
+
+  @Test
+  public void testContinueFromAfterNewline() {
+    EditIterator iter = new EditIterator(lines, 0);
+    iter.advance(4);
+    assertLineChsEqual(LineCharacter.create(2, 2), iter.advance(6));
+  }
+
+  @Test
+  public void testAcrossMultipleLines() {
+    EditIterator iter = new EditIterator(lines, 0);
+    assertLineChsEqual(LineCharacter.create(2, 2), iter.advance(10));
+  }
+}

gerrit-gwtui/src/test/resources/META-INF/gwt-test-utils.properties

@@ -0,0 +1 @@
+com.google.gerrit.GerritGwtUI = gwt-module