opendev/gerrit
Code Issues Proposed changes

PatchSet: Change isRef to isChangeRef

Browse Source 
The name isChangeRef is clearer.

Update the replication plugin to use the new method name.

For backwards compatibility for other plugins, keep the isRef method
and mark it as deprecated.

Change-Id: I99c6b2daeaf6c3a5e5d948ae32e0751f3ffedf31
This commit is contained in:
David Pursehouse
2015-10-08 17:49:14 +09:00
parent 22345d1c2a
commit 7b9f5910fb
4 changed files with 13 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
gerrit-reviewdb/src/test/java/com/google/gerrit/reviewdb/client/PatchSetTest.java
View File

@@ -84,13 +84,13 @@ public class PatchSetTest {
}
private static void assertRef(int changeId, int psId, String refName) {
assertThat(PatchSet.isRef(refName)).isTrue();
assertThat(PatchSet.isChangeRef(refName)).isTrue();
assertThat(PatchSet.Id.fromRef(refName))
.isEqualTo(new PatchSet.Id(new Change.Id(changeId), psId));
}
private static void assertNotRef(String refName) {
assertThat(PatchSet.isRef(refName)).isFalse();
assertThat(PatchSet.isChangeRef(refName)).isFalse();
assertThat(PatchSet.Id.fromRef(refName)).isNull();
}
}