opendev/gerrit
Code Issues Proposed changes

Merge "Double-encode search query"

Browse Source
This commit is contained in:
Andrew Bonventre
2016-07-15 16:39:33 +00:00
committed by Gerrit Code Review
parent 34db49692b 7caa3d7d30
commit 7bcc753296
2 changed files with 9 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

3
polygerrit-ui/app/elements/core/gr-search-bar/gr-search-bar.js
View File

@@ -54,7 +54,8 @@
_preventDefaultAndNavigateToInputVal: function(e) { _preventDefaultAndNavigateToInputVal: function(e) {
e.preventDefault(); e.preventDefault();
Polymer.dom(e).rootTarget.blur(); Polymer.dom(e).rootTarget.blur();
page.show('/q/' + this._inputVal); // @see Issue 4255.
page.show('/q/' + encodeURIComponent(encodeURIComponent(this._inputVal)));
}, },
_handleKey: function(e) { _handleKey: function(e) {

7
polygerrit-ui/app/elements/core/gr-search-bar/gr-search-bar_test.html
View File

@@ -71,5 +71,12 @@ limitations under the License.
MockInteractions.pressAndReleaseKeyOn(element.$.searchInput, 13); MockInteractions.pressAndReleaseKeyOn(element.$.searchInput, 13);
}); });
test('search query should be double-escaped', function() {
var showStub = sinon.stub(page, 'show');
element._inputVal = 'fate/stay';
MockInteractions.pressAndReleaseKeyOn(element.$.searchInput, 13);
assert.equal(showStub.lastCall.args[0], '/q/fate%252Fstay');
showStub.restore();
});
}); });
</script> </script>