opendev/gerrit
Code Issues Proposed changes

Use simpler isTrue() and isFalse() in tests

Browse Source 
Change-Id: Ib77acebcafcd4ba89b345d2f3ff1a4a98191329a
This commit is contained in:
Changcheng Xiao
2018-01-10 17:10:49 +01:00
committed by David Pursehouse
parent 2d2968ea06
commit 7bcf5b715d
5 changed files with 13 additions and 15 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
javatests/com/google/gerrit/acceptance/api/change/DisablePrivateChangesIT.java
View File

@@ -47,7 +47,7 @@ public class DisablePrivateChangesIT extends AbstractDaemonTest {
public void createPrivateChangeWithDisablePrivateChangesFalse() throws Exception {
ChangeInput input = new ChangeInput(project.get(), "master", "empty change");
input.isPrivate = true;
assertThat(gApi.changes().create(input).get().isPrivate).isEqualTo(true);
assertThat(gApi.changes().create(input).get().isPrivate).isTrue();
}
@Test
@@ -84,7 +84,7 @@ public class DisablePrivateChangesIT extends AbstractDaemonTest {
public void pushPrivatesWithDisablePrivateChangesFalse() throws Exception {
PushOneCommit.Result result =
pushFactory.create(db, admin.getIdent(), testRepo).to("refs/for/master%private");
assertThat(result.getChange().change().isPrivate()).isEqualTo(true);
assertThat(result.getChange().change().isPrivate()).isTrue();
}
@Test
@@ -92,11 +92,11 @@ public class DisablePrivateChangesIT extends AbstractDaemonTest {
RevCommit initialHead = getRemoteHead();
PushOneCommit.Result result =
pushFactory.create(db, admin.getIdent(), testRepo).to("refs/for/master%draft");
assertThat(result.getChange().change().isPrivate()).isEqualTo(true);
assertThat(result.getChange().change().isPrivate()).isTrue();
testRepo.reset(initialHead);
result = pushFactory.create(db, admin.getIdent(), testRepo).to("refs/drafts/master");
assertThat(result.getChange().change().isPrivate()).isEqualTo(true);
assertThat(result.getChange().change().isPrivate()).isTrue();
}
@Test