opendev/gerrit
Code Issues Proposed changes

Use simpler isTrue() and isFalse() in tests

Browse Source 
Change-Id: Ib77acebcafcd4ba89b345d2f3ff1a4a98191329a
This commit is contained in:
Changcheng Xiao
2018-01-10 17:10:49 +01:00
committed by David Pursehouse
parent 2d2968ea06
commit 7bcf5b715d
5 changed files with 13 additions and 15 deletions
Download Patch File Download Diff File Expand all files Collapse all files

10
javatests/com/google/gerrit/acceptance/rest/change/PrivateByDefaultIT.java
View File

@@ -46,7 +46,7 @@ public class PrivateByDefaultIT extends AbstractDaemonTest {
public void createChangeWithPrivateByDefaultEnabled() throws Exception {
setPrivateByDefault(project2, InheritableBoolean.TRUE);
ChangeInput input = new ChangeInput(project2.get(), "master", "empty change");
assertThat(gApi.changes().create(input).get().isPrivate).isEqualTo(true);
assertThat(gApi.changes().create(input).get().isPrivate).isTrue();
}
@Test
@@ -86,7 +86,7 @@ public class PrivateByDefaultIT extends AbstractDaemonTest {
@Test
public void pushWithPrivateByDefaultEnabled() throws Exception {
setPrivateByDefault(project2, InheritableBoolean.TRUE);
assertThat(createChange(project2).getChange().change().isPrivate()).isEqualTo(true);
assertThat(createChange(project2).getChange().change().isPrivate()).isTrue();
}
@Test
@@ -97,18 +97,18 @@ public class PrivateByDefaultIT extends AbstractDaemonTest {
.getChange()
.change()
.isPrivate())
.isEqualTo(false);
.isFalse();
}
@Test
public void pushWithPrivateByDefaultDisabled() throws Exception {
assertThat(createChange(project2).getChange().change().isPrivate()).isEqualTo(false);
assertThat(createChange(project2).getChange().change().isPrivate()).isFalse();
}
@Test
public void pushBypassPrivateByDefaultInherited() throws Exception {
setPrivateByDefault(project1, InheritableBoolean.TRUE);
assertThat(createChange(project2).getChange().change().isPrivate()).isEqualTo(true);
assertThat(createChange(project2).getChange().change().isPrivate()).isTrue();
}
@Test