opendev/gerrit
Code Issues Proposed changes

PRED_commit_edits_2: Fix build on other platform

Browse Source 
It seems, that this JDK bug: [1] is still present on other platform.
See this issue for more background: [2].

[1] https://bugs.openjdk.java.net/browse/JDK-8039214
[2] https://github.com/bazelbuild/bazel/issues/3965

Change-Id: I37c0b682aa82652125d7ea7001a7cf2dd3da2de9
This commit is contained in:
David Ostrovsky
2017-11-15 08:46:22 +01:00
committed by David Ostrovsky
parent cf6931ec2b
commit 7be80d9dcf
1 changed files with 3 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
java/gerrit/PRED_commit_edits_2.java
View File

@@ -96,7 +96,9 @@ public class PRED_commit_edits_2 extends Predicate.P2 {
if (fileRegex.matcher(newName).find()
|| (oldName != null && fileRegex.matcher(oldName).find())) {
List<Edit> edits = entry.getEdits();
// This cast still seems to be needed on JDK 8 as workaround for:
// https://bugs.openjdk.java.net/browse/JDK-8039214
List<Edit> edits = (List<Edit>) entry.getEdits();
if (edits.isEmpty()) {
continue;