opendev/gerrit
Code Issues Proposed changes

Remove unused insert method from secondary index interface

Browse Source 
The `insert` method is not used anywhere.  The `replace` method is
used instead.

Change-Id: Ie47253149cacde9a0824e4dee4d80313acd33188
This commit is contained in:
David Pursehouse
2014-07-17 12:12:50 +09:00
parent da5e5e76a1
commit 7bf7e49621
4 changed files with 3 additions and 58 deletions
Download Patch File Download Diff File Expand all files Collapse all files

19
gerrit-solr/src/main/java/com/google/gerrit/solr/SolrChangeIndex.java
View File

@@ -146,25 +146,6 @@ class SolrChangeIndex implements ChangeIndex, LifecycleListener {
stop();
}
@Override
public void insert(ChangeData cd) throws IOException {
String id = cd.getId().toString();
SolrInputDocument doc = toDocument(cd);
try {
if (cd.change().getStatus().isOpen()) {
closedIndex.deleteById(id);
openIndex.add(doc);
} else {
openIndex.deleteById(id);
closedIndex.add(doc);
}
} catch (OrmException | SolrServerException e) {
throw new IOException(e);
}
commit(openIndex);
commit(closedIndex);
}
@Override
public void replace(ChangeData cd) throws IOException {
String id = cd.getId().toString();