opendev/gerrit
Code Issues Proposed changes

Merge "EventUtil: Exclude some more ListChangesOptions"

Browse Source
This commit is contained in:
Shawn Pearce 2017-03-07 17:04:15 +00:00 committed by Gerrit Code Review
commit 7c10e63ffd
1 changed files with 20 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

23
gerrit-server/src/main/java/com/google/gerrit/server/extensions/events/EventUtil.java
View File

@ -14,6 +14,8 @@
package com.google.gerrit.server.extensions.events;
import com.google.common.collect.ImmutableSet;
import com.google.common.collect.Sets;
import com.google.gerrit.extensions.client.ListChangesOption;
import com.google.gerrit.extensions.common.AccountInfo;
import com.google.gerrit.extensions.common.ApprovalInfo;
@ -43,6 +45,23 @@ import org.slf4j.LoggerFactory;
public class EventUtil {
private static final Logger log = LoggerFactory.getLogger(EventUtil.class);
private static final ImmutableSet<ListChangesOption> CHANGE_OPTIONS;
static {
EnumSet<ListChangesOption> opts = EnumSet.allOf(ListChangesOption.class);
// Some options, like actions, are expensive to compute because they potentially have to walk
// lots of history and inspect lots of other changes.
opts.remove(ListChangesOption.CHANGE_ACTIONS);
opts.remove(ListChangesOption.CURRENT_ACTIONS);
// CHECK suppresses some exceptions on corrupt changes, which is not appropriate for passing
// through the event system as we would rather let them propagate.
opts.remove(ListChangesOption.CHECK);
CHANGE_OPTIONS = Sets.immutableEnumSet(opts);
}
private final ChangeData.Factory changeDataFactory;
private final Provider<ReviewDb> db;
private final ChangeJson changeJson;
@ -54,9 +73,7 @@ public class EventUtil {
Provider<ReviewDb> db) {
this.changeDataFactory = changeDataFactory;
this.db = db;
EnumSet<ListChangesOption> opts = EnumSet.allOf(ListChangesOption.class);
opts.remove(ListChangesOption.CHECK);
this.changeJson = changeJsonFactory.create(opts);
this.changeJson = changeJsonFactory.create(CHANGE_OPTIONS);
}
public ChangeInfo changeInfo(Change change) throws OrmException {