opendev/gerrit
Code Issues Proposed changes

Don't prefix range comments with line number twice

Browse Source 
Review emails currently show the line number of the first line of
a range comment twice:

	Line 136: Line 136: Plugin Name
		: ~~~~~~~~~~~~~

Drop the first line number prefix.

Change-Id: I4e1ba22282326bf63c887482ad72d4d5a87df884
This commit is contained in:
Jonathan Nieder
2013-09-18 16:13:15 -07:00
parent 9ef5abd5cf
commit 7ce95b03b9
1 changed files with 0 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

1
gerrit-server/src/main/java/com/google/gerrit/server/mail/CommentSender.java
View File

@@ -170,7 +170,6 @@ public class CommentSender extends ReplyToChangeSender {
CommentRange range = comment.getRange(); CommentRange range = comment.getRange();
if (range != null) { if (range != null) {
String prefix = String.format("Line %d: ", range.getStartLine()); String prefix = String.format("Line %d: ", range.getStartLine());
out.append(prefix);
for (int n = range.getStartLine(); n <= range.getEndLine(); n++) { for (int n = range.getStartLine(); n <= range.getEndLine(); n++) {
out.append(n == range.getStartLine() out.append(n == range.getStartLine()
? prefix ? prefix