opendev/gerrit
Code Issues Proposed changes

Merge "Fix padding and other css styles is textareas"

Browse Source
This commit is contained in:
Tao Zhou
2020-01-07 13:43:24 +00:00
committed by Gerrit Code Review
parent 32da8d5d18 0773d83413
commit 7d06780fdc
11 changed files with 9 additions and 56 deletions
Download Patch File Download Diff File Expand all files Collapse all files

7
polygerrit-ui/app/elements/change/gr-confirm-abandon-dialog/gr-confirm-abandon-dialog.html
View File

@@ -45,14 +45,7 @@ limitations under the License.
font-family: var(--monospace-font-family);
font-size: var(--font-size-mono);
line-height: var(--line-height-mono);
padding: 0;
width: 73ch; /* Add a char to account for the border. */
--iron-autogrow-textarea {
border: 1px solid var(--border-color);
box-sizing: border-box;
font-family: var(--monospace-font-family);
}
}
</style>
<gr-dialog

9
polygerrit-ui/app/elements/change/gr-confirm-cherrypick-dialog/gr-confirm-cherrypick-dialog.html
View File

@@ -47,18 +47,11 @@ limitations under the License.
display: block;
width: 100%;
}
.main .message {
width: 100%;
}
iron-autogrow-textarea {
font-family: var(--monospace-font-family);
font-size: var(--font-size-mono);
line-height: var(--line-height-mono);
padding: 0;
--iron-autogrow-textarea: {
font-family: var(--monospace-font-family);
width: 72ch;
};
width: 73ch; /* Add a char to account for the border. */
}
</style>
<gr-dialog

3
polygerrit-ui/app/elements/change/gr-confirm-move-dialog/gr-confirm-move-dialog.html
View File

@@ -37,9 +37,6 @@ limitations under the License.
label {
cursor: pointer;
}
iron-autogrow-textarea {
padding: 0;
}
.main {
display: flex;
flex-direction: column;

7
polygerrit-ui/app/elements/change/gr-confirm-revert-dialog/gr-confirm-revert-dialog.html
View File

@@ -41,14 +41,7 @@ limitations under the License.
font-family: var(--monospace-font-family);
font-size: var(--font-size-mono);
line-height: var(--line-height-mono);
padding: 0;
width: 73ch; /* Add a char to account for the border. */
--iron-autogrow-textarea {
border: 1px solid var(--border-color);
box-sizing: border-box;
font-family: var(--monospace-font-family);
}
}
</style>
<gr-dialog

9
polygerrit-ui/app/elements/change/gr-confirm-revert-submission-dialog/gr-confirm-revert-submission-dialog.html
View File

@@ -40,14 +40,9 @@ limitations under the License.
}
iron-autogrow-textarea {
font-family: var(--monospace-font-family);
padding: 0;
font-size: var(--font-size-mono);
line-height: var(--line-height-mono);
width: 73ch; /* Add a char to account for the border. */
--iron-autogrow-textarea {
border: 1px solid var(--border-color);
box-sizing: border-box;
font-family: var(--monospace-font-family);
}
}
</style>
<gr-dialog

4
polygerrit-ui/app/elements/shared/gr-comment/gr-comment.html
View File

@@ -43,10 +43,6 @@ limitations under the License.
display: block;
font-family: var(--font-family);
padding: var(--spacing-m);
--iron-autogrow-textarea: {
box-sizing: border-box;
padding: 2px;
};
}
:host([disabled]) {
pointer-events: none;

7
polygerrit-ui/app/elements/shared/gr-confirm-delete-comment-dialog/gr-confirm-delete-comment-dialog.html
View File

@@ -45,14 +45,7 @@ limitations under the License.
font-family: var(--monospace-font-family);
font-size: var(--font-size-mono);
line-height: var(--line-height-mono);
padding: 0;
width: 73ch; /* Add a char to account for the border. */
--iron-autogrow-textarea {
border: 1px solid var(--border-color);
box-sizing: border-box;
font-family: var(--monospace-font-family);
}
}
</style>
<gr-dialog

4
polygerrit-ui/app/elements/shared/gr-editable-content/gr-editable-content.html
View File

@@ -41,9 +41,11 @@ limitations under the License.
background-color: var(--view-background-color);
width: 100%;
/* You have to also repeat everything from shared-styles here, because
you can only *replace* --iron-autogrow-textarea vars as a whole. */
--iron-autogrow-textarea: {
padding: var(--spacing-m);
box-sizing: border-box;
padding: var(--spacing-m);
overflow-y: hidden;
white-space: pre;
};

4
polygerrit-ui/app/elements/shared/gr-textarea/gr-textarea.html
View File

@@ -59,11 +59,7 @@ limitations under the License.
visibility: visible;
white-space: normal;
}
/*This is needed to not add a scroll bar on the side of gr-textarea
since there is 2px of padding in iron-autogrow-textarea for the
native textarea*/
iron-autogrow-textarea {
padding: 2px;
position: relative;
/** This is needed for firefox */

7
polygerrit-ui/app/styles/gr-form-styles.html
View File

@@ -93,15 +93,8 @@ limitations under the License.
width: 100%;
}
.gr-form-styles iron-autogrow-textarea {
border: none;
height: auto;
min-height: 4em;
--iron-autogrow-textarea: {
border: 1px solid var(--border-color);
border-radius: var(--border-radius);
box-sizing: border-box;
padding: var(--spacing-s);
}
}
.gr-form-styles gr-autocomplete {
width: 14em;

4
polygerrit-ui/app/styles/shared-styles.html
View File

@@ -53,13 +53,15 @@ limitations under the License.
color: var(--primary-text-color);
border: 1px solid var(--border-color);
border-radius: var(--border-radius);
padding: 0;
box-sizing: border-box;
/* iron-autogrow-textarea has a "-webkit-appearance: textarea" :host
css rule, which prevents overriding the border color. Clear that. */
-webkit-appearance: none;
--iron-autogrow-textarea: {
padding: 4px;
box-sizing: border-box;
padding: var(--spacing-s);
};
}
a {