opendev/gerrit
Code Issues Proposed changes

Use system fonts in favor of Open Sans

Browse Source 
This removes the dependency on Open Sans to be loaded as a
web font.

Also reduce base font size to 13px with a line height of 1.4

Change-Id: I18e502457554dce46098e339c1482dd65cbf1120
This commit is contained in:
Andrew Bonventre
2016-08-17 10:59:53 -07:00
parent 93a4c8e42d
commit 7d0b10272c
4 changed files with 3 additions and 143 deletions
Download Patch File Download Diff File Expand all files Collapse all files

1
polygerrit-ui/BUCK
View File

@@ -26,7 +26,6 @@ genrule(
]), ]),
srcs = [ srcs = [
'//lib/fonts:sourcecodepro', '//lib/fonts:sourcecodepro',
'//lib/fonts:opensans',
], ],
out = 'fonts.zip', out = 'fonts.zip',
visibility = ['PUBLIC'], visibility = ['PUBLIC'],

2
polygerrit-ui/app/styles/app-theme.html
View File

@@ -21,7 +21,7 @@ limitations under the License.
--default-text-color: #000; --default-text-color: #000;
--view-background-color: #fff; --view-background-color: #fff;
--default-horizontal-margin: 1.25rem; --default-horizontal-margin: 1.25rem;
--font-family: 'Open Sans', sans-serif; --font-family: -apple-system, BlinkMacSystemFont, 'Segoe UI', Roboto, Oxygen, Ubuntu, Cantarell, 'Open Sans', 'Helvetica Neue', sans-serif;
--monospace-font-family: 'Source Code Pro', Menlo, 'Lucida Console', Monaco, monospace; --monospace-font-family: 'Source Code Pro', Menlo, 'Lucida Console', Monaco, monospace;
--iron-overlay-backdrop: { --iron-overlay-backdrop: {

140
polygerrit-ui/app/styles/fonts.css
View File

@@ -1,143 +1,3 @@
/* cyrillic-ext */
@font-face {
font-family: 'Open Sans';
font-style: normal;
font-weight: 400;
src: local('Open Sans'), local('OpenSans'),
url(../fonts/OpenSans-Regular.woff2) format('woff2'),
url(../fonts/OpenSans-Regular.woff) format('woff');
unicode-range: U+0460-052F, U+20B4, U+2DE0-2DFF, U+A640-A69F;
}
/* cyrillic */
@font-face {
font-family: 'Open Sans';
font-style: normal;
font-weight: 400;
src: local('Open Sans'), local('OpenSans'),
url(../fonts/OpenSans-Regular.woff2) format('woff2'),
url(../fonts/OpenSans-Regular.woff) format('woff');
unicode-range: U+0400-045F, U+0490-0491, U+04B0-04B1, U+2116;
}
/* greek-ext */
@font-face {
font-family: 'Open Sans';
font-style: normal;
font-weight: 400;
src: local('Open Sans'), local('OpenSans'),
url(../fonts/OpenSans-Regular.woff2) format('woff2'),
url(../fonts/OpenSans-Regular.woff) format('woff');
unicode-range: U+1F00-1FFF;
}
/* greek */
@font-face {
font-family: 'Open Sans';
font-style: normal;
font-weight: 400;
src: local('Open Sans'), local('OpenSans'),
url(../fonts/OpenSans-Regular.woff2) format('woff2'),
url(../fonts/OpenSans-Regular.woff) format('woff');
unicode-range: U+0370-03FF;
}
/* vietnamese */
@font-face {
font-family: 'Open Sans';
font-style: normal;
font-weight: 400;
src: local('Open Sans'), local('OpenSans'),
url(../fonts/OpenSans-Regular.woff2) format('woff2'),
url(../fonts/OpenSans-Regular.woff) format('woff');
unicode-range: U+0102-0103, U+1EA0-1EF1, U+20AB;
}
/* latin-ext */
@font-face {
font-family: 'Open Sans';
font-style: normal;
font-weight: 400;
src: local('Open Sans'), local('OpenSans'),
url(../fonts/OpenSans-Regular.woff2) format('woff2'),
url(../fonts/OpenSans-Regular.woff) format('woff');
unicode-range: U+0100-024F, U+1E00-1EFF, U+20A0-20AB, U+20AD-20CF, U+2C60-2C7F, U+A720-A7FF;
}
/* latin */
@font-face {
font-family: 'Open Sans';
font-style: normal;
font-weight: 400;
src: local('Open Sans'), local('OpenSans'),
url(../fonts/OpenSans-Regular.woff2) format('woff2'),
url(../fonts/OpenSans-Regular.woff) format('woff');
unicode-range: U+0000-00FF, U+0131, U+0152-0153, U+02C6, U+02DA, U+02DC, U+2000-206F, U+2074, U+20AC, U+2212, U+2215, U+E0FF, U+EFFD, U+F000;
}
/* cyrillic-ext */
@font-face {
font-family: 'Open Sans';
font-style: normal;
font-weight: 700;
src: local('Open Sans Bold'), local('OpenSans-Bold'),
url(../fonts/OpenSans-Bold.woff2) format('woff2'),
url(../fonts/OpenSans-Bold.woff) format('woff');
unicode-range: U+0460-052F, U+20B4, U+2DE0-2DFF, U+A640-A69F;
}
/* cyrillic */
@font-face {
font-family: 'Open Sans';
font-style: normal;
font-weight: 700;
src: local('Open Sans Bold'), local('OpenSans-Bold'),
url(../fonts/OpenSans-Bold.woff2) format('woff2'),
url(../fonts/OpenSans-Bold.woff) format('woff');
unicode-range: U+0400-045F, U+0490-0491, U+04B0-04B1, U+2116;
}
/* greek-ext */
@font-face {
font-family: 'Open Sans';
font-style: normal;
font-weight: 700;
src: local('Open Sans Bold'), local('OpenSans-Bold'),
url(../fonts/OpenSans-Bold.woff2) format('woff2'),
url(../fonts/OpenSans-Bold.woff) format('woff');
unicode-range: U+1F00-1FFF;
}
/* greek */
@font-face {
font-family: 'Open Sans';
font-style: normal;
font-weight: 700;
src: local('Open Sans Bold'), local('OpenSans-Bold'),
url(../fonts/OpenSans-Bold.woff2) format('woff2'),
url(../fonts/OpenSans-Bold.woff) format('woff');
unicode-range: U+0370-03FF;
}
/* vietnamese */
@font-face {
font-family: 'Open Sans';
font-style: normal;
font-weight: 700;
src: local('Open Sans Bold'), local('OpenSans-Bold'),
url(../fonts/OpenSans-Bold.woff2) format('woff2'),
url(../fonts/OpenSans-Bold.woff) format('woff');
unicode-range: U+0102-0103, U+1EA0-1EF1, U+20AB;
}
/* latin-ext */
@font-face {
font-family: 'Open Sans';
font-style: normal;
font-weight: 700;
src: local('Open Sans Bold'), local('OpenSans-Bold'),
url(../fonts/OpenSans-Bold.woff2) format('woff2'),
url(../fonts/OpenSans-Bold.woff) format('woff');
unicode-range: U+0100-024F, U+1E00-1EFF, U+20A0-20AB, U+20AD-20CF, U+2C60-2C7F, U+A720-A7FF;
}
/* latin */
@font-face {
font-family: 'Open Sans';
font-style: normal;
font-weight: 700;
src: local('Open Sans Bold'), local('OpenSans-Bold'),
url(../fonts/OpenSans-Bold.woff2) format('woff2'),
url(../fonts/OpenSans-Bold.woff) format('woff');
unicode-range: U+0000-00FF, U+0131, U+0152-0153, U+02C6, U+02DA, U+02DC, U+2000-206F, U+2074, U+20AC, U+2212, U+2215, U+E0FF, U+EFFD, U+F000;
}
/* latin-ext */ /* latin-ext */
@font-face { @font-face {
font-family: 'Source Code Pro'; font-family: 'Source Code Pro';

3
polygerrit-ui/app/styles/main.css
View File

@@ -30,5 +30,6 @@ body {
transition: none; /* Override the default Polymer fade-in. */ transition: none; /* Override the default Polymer fade-in. */
} }
body { body {
font: 14px 'Open Sans', sans-serif; font: 13px -apple-system, BlinkMacSystemFont, 'Segoe UI', Roboto, Oxygen, Ubuntu, Cantarell, 'Open Sans', 'Helvetica Neue', sans-serif;
line-height: 1.4;
} }