opendev/gerrit
Code Issues Proposed changes

ProjectConfig: Don't use JGit's StringUtils to convert to lower case

Browse Source 
Instead use Java's String built-in toLowerCase method.

Change-Id: Ic5bd099356b7ad08b6ba70d25cfb1043e84c272e
This commit is contained in:
David Pursehouse
2018-05-17 14:19:34 +09:00
parent 3cee96f94c
commit 7d1dfc7bc7
1 changed files with 2 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
gerrit-server/src/main/java/com/google/gerrit/server/git/ProjectConfig.java
View File

@@ -65,6 +65,7 @@ import java.util.HashMap;
import java.util.HashSet;
import java.util.LinkedHashMap;
import java.util.List;
import java.util.Locale;
import java.util.Map;
import java.util.Map.Entry;
import java.util.Set;
@@ -75,7 +76,6 @@ import org.eclipse.jgit.lib.CommitBuilder;
import org.eclipse.jgit.lib.Config;
import org.eclipse.jgit.lib.ObjectId;
import org.eclipse.jgit.transport.RefSpec;
import org.eclipse.jgit.util.StringUtils;
public class ProjectConfig extends VersionedMetaData implements ValidationError.Sink {
public static final String COMMENTLINK = "commentlink";
@@ -1181,7 +1181,7 @@ public class ProjectConfig extends VersionedMetaData implements ValidationError.
List<String> types = Lists.newArrayListWithCapacity(4);
for (NotifyType t : NotifyType.values()) {
if (nc.isNotify(t)) {
types.add(StringUtils.toLowerCase(t.name()));
types.add(t.name().toLowerCase(Locale.US));
}
}
rc.setStringList(NOTIFY, nc.getName(), KEY_TYPE, types);