opendev/gerrit
Code Issues Proposed changes

Correct right border of binary header lines in side-by-side diffs

Browse Source 
While the border between the two right most columns is typically drawn
in the rightmost column, binary header rows drew it in the rightmost
but one column. That made the line between the two columns jump a few
pixels between rows. We now draw the line number columns of binary
header rows via the available helper method, and remove the now
unnecessary right border of the main column.

Change-Id: I5e2d0c0cc7b9fee94c0a060a8bbd9d3d71d25600
This commit is contained in:
Christian Aistleitner
2013-04-24 20:13:30 +02:00
parent 93d3b555f2
commit 7dac021561
2 changed files with 2 additions and 8 deletions
Download Patch File Download Diff File Expand all files Collapse all files

9
gerrit-gwtui/src/main/java/com/google/gerrit/client/patches/SideBySideTable.java
View File

@@ -442,10 +442,7 @@ public class SideBySideTable extends AbstractPatchContentTable {
m.addStyleName(Gerrit.RESOURCES.css().iconCell());
m.closeTd();
m.openTd();
m.setStyleName(Gerrit.RESOURCES.css().lineNumber());
m.nbsp();
m.closeTd();
appendLineNumber(m, false);
m.openTd();
m.setStyleName(Gerrit.RESOURCES.css().sideBySideTableBinaryHeader());
@@ -453,9 +450,7 @@ public class SideBySideTable extends AbstractPatchContentTable {
m.append(line);
m.closeTd();
m.openTd();
m.nbsp();
m.closeTd();
appendLineNumber(m, true);
m.closeTr();
}