opendev/gerrit
Code Issues Proposed changes

Remove stray get() call in ChangeControl#isAssignee

Browse Source 
When 138aec1244 (Assignee in ReviewDb,
2016-09-23) converted currentAssignee from an Optional<Account.Id>
to an Account.Id, it forgot to remove this get() call.  As a result
the method always returns false.

Noticed by error-prone
(http://errorprone.info/bugpattern/EqualsIncompatibleType).

Change-Id: I13c778c7e1afdcb70c2790da12f770c87d8197ec
This commit is contained in:
Jonathan Nieder
2016-10-26 10:43:46 -07:00
parent a2cca5be9f
commit 7f40029a0b
1 changed files with 1 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
gerrit-server/src/main/java/com/google/gerrit/server/project/ChangeControl.java
View File

@@ -370,7 +370,7 @@ public class ChangeControl {
Account.Id currentAssignee = notes.getChange().getAssignee(); Account.Id currentAssignee = notes.getChange().getAssignee();
if (currentAssignee != null && getUser().isIdentifiedUser()) { if (currentAssignee != null && getUser().isIdentifiedUser()) {
Account.Id id = getUser().getAccountId(); Account.Id id = getUser().getAccountId();
return id.equals(currentAssignee.get()); return id.equals(currentAssignee);
} }
return false; return false;
} }