opendev/gerrit
Code Issues Proposed changes

ldap.Helper: Kill "assuming empty group membership" logspam

Browse Source 
Change I75fd86fb9 added catching of AccountException and replaced the
stack trace log with a warning:

  "Account <name> not found: assuming empty group membership"

The intention was to prevent excessive logging, but these warnings
themselves are filling up the log.

Change-Id: Id52830dbcab1f7434960a47cb11e5e559a6f650a
This commit is contained in:
David Pursehouse
2016-02-03 15:25:50 +09:00
parent a2b943bff2
commit 7f64ab66b8
1 changed files with 0 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
gerrit-server/src/main/java/com/google/gerrit/server/auth/ldap/Helper.java
View File

@@ -224,8 +224,6 @@ import javax.security.auth.login.LoginException;
try { try {
account = findAccount(schema, ctx, username, false); account = findAccount(schema, ctx, username, false);
} catch (AccountException e) { } catch (AccountException e) {
LdapRealm.log.warn("Account " + username +
" not found, assuming empty group membership");
return Collections.emptySet(); return Collections.emptySet();
} }
} }
@@ -247,8 +245,6 @@ import javax.security.auth.login.LoginException;
try { try {
account = findAccount(schema, ctx, username, true); account = findAccount(schema, ctx, username, true);
} catch (AccountException e) { } catch (AccountException e) {
LdapRealm.log.warn("Account " + username +
" not found, assuming empty group membership");
return Collections.emptySet(); return Collections.emptySet();
} }
} }