opendev/gerrit
Code Issues Proposed changes

Split up canSubmit()

Browse Source 
Have a new function resultsToSubmitRecord that converts the prolog
results into gerrit submitrecords.

The resultsToSubmitRecord will be used for testing prolog submit
rules on a live server.

Change-Id: I6ba95ef93634ab3e3872c03fb12de1d1c19c32b5
This commit is contained in:
Johan Björk
2012-08-02 15:51:49 +02:00
parent b5b04ecd58
commit 7fcb0f2dce
1 changed files with 12 additions and 6 deletions
Download Patch File Download Diff File Expand all files Collapse all files

18
gerrit-server/src/main/java/com/google/gerrit/server/project/ChangeControl.java
View File

@@ -443,12 +443,18 @@ public class ChangeControl {
return ruleError("Project submit rule has no solution");
}
// Convert the results from Prolog Cafe's format to Gerrit's common format.
// can_submit/1 terminates when an ok(P) record is found. Therefore walk
// the results backwards, using only that ok(P) record if it exists. This
// skips partial results that occur early in the output. Later after the loop
// the out collection is reversed to restore it to the original ordering.
//
return resultsToSubmitRecord(submitRule, results);
}
/**
* Convert the results from Prolog Cafe's format to Gerrit's common format.
*
* can_submit/1 terminates when an ok(P) record is found. Therefore walk
* the results backwards, using only that ok(P) record if it exists. This
* skips partial results that occur early in the output. Later after the loop
* the out collection is reversed to restore it to the original ordering.
*/
public List<SubmitRecord> resultsToSubmitRecord(Term submitRule, List<Term> results) {
List<SubmitRecord> out = new ArrayList<SubmitRecord>(results.size());
for (int resultIdx = results.size() - 1; 0 <= resultIdx; resultIdx--) {
Term submitRecord = results.get(resultIdx);