opendev/gerrit
Code Issues Proposed changes

Initialize the submodule commit message buffer

Browse Source 
Appending to a String that is null causes the null value to be coerced
to a string literal, such that the previously-null String value becomes
a string literal "null".

Change-Id: I07a4b071fabbb0b4a28403603884cb05d777c01b
Bug: Issue 1396
This commit is contained in:
Joe Hansche
2012-05-18 18:22:50 -04:00
parent b3a402124f
commit 8001dc83f3
1 changed files with 3 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files

3
gerrit-server/src/main/java/com/google/gerrit/server/git/SubmoduleOp.java
View File

@@ -202,6 +202,9 @@ public class SubmoduleOp {
if (!subscribers.isEmpty()) { if (!subscribers.isEmpty()) {
String msgbuf = msg; String msgbuf = msg;
if (msgbuf == null) { if (msgbuf == null) {
// Initialize the message buffer
msgbuf = "";
// The first updatedBranch on a cascade event of automatic // The first updatedBranch on a cascade event of automatic
// updates of repos is added to updatedSubscribers set so // updates of repos is added to updatedSubscribers set so
// if we face a situation having // if we face a situation having