Enable no-confusing-arrow and newline-per-chained-call

Change-Id: I3b1a88301cfacf75593dea5e19a2e6b6b2869740

polygerrit-ui/app/.eslintrc.json

@@ -21,6 +21,8 @@
     "flushAsynchronousOperations": false
   },
   "rules": {
+    "no-confusing-arrow": "error",
+    "newline-per-chained-call": ["error", { "ignoreChainWithDepth": 2 }],
     "arrow-parens": ["error", "as-needed"],
     "block-spacing": ["error", "always"],
     "brace-style": ["error", "1tbs", { "allowSingleLine": true }],

polygerrit-ui/app/behaviors/gr-access-behavior/gr-access-behavior.html

@@ -139,12 +139,14 @@ limitations under the License.
      */
     toSortedArray(obj) {
       if (!obj) { return []; }
-      return Object.keys(obj).map(key => {
+      return Object.keys(obj)
+          .map(key => {
             return {
               id: key,
               value: obj[key],
             };
-      }).sort((a, b) => {
+          })
+          .sort((a, b) => {
             // Since IDs are strings, use localeCompare.
             return a.id.localeCompare(b.id);
           });

polygerrit-ui/app/behaviors/gr-patch-set-behavior/gr-patch-set-behavior.html

@@ -124,9 +124,9 @@ limitations under the License.
       // Map a normal patchNum to 2 * (patchNum - 1) + 1... I.e. 1 -> 1,
       // 2 -> 3, 3 -> 5, etc.
       // Map an edit to the patchNum of parent*2... I.e. edit on 2 -> 4.
-      const num = r => r._number === Gerrit.PatchSetBehavior.EDIT_NAME ?
+      const num = r => (r._number === Gerrit.PatchSetBehavior.EDIT_NAME ?
         2 * editParent :
-        2 * (r._number - 1) + 1;
+        2 * (r._number - 1) + 1);
       return revisions.sort((a, b) => num(b) - num(a));
     },
 

polygerrit-ui/app/elements/admin/gr-repo-access/gr-repo-access_test.html

@@ -579,7 +579,8 @@ limitations under the License.
           remove: {},
         };
 
-        element.$$('gr-access-section').$$('gr-permission')._handleAddRuleItem(
+        element.$$('gr-access-section').$$('gr-permission')
+            ._handleAddRuleItem(
                 {detail: {value: {id: 'Maintainers'}}});
 
         flushAsynchronousOperations();

polygerrit-ui/app/elements/admin/gr-repo-dashboards/gr-repo-dashboards.js

@@ -54,7 +54,7 @@
 
         // Group by ref and sort by id.
         const dashboards = res.concat.apply([], res).sort((a, b) =>
-          a.id < b.id ? -1 : 1);
+          (a.id < b.id ? -1 : 1));
         const dashboardsByRef = {};
         dashboards.forEach(d => {
           if (!dashboardsByRef[d.ref]) {
@@ -64,7 +64,8 @@
         });
 
         const dashboardBuilder = [];
-        Object.keys(dashboardsByRef).sort().forEach(ref => {
+        Object.keys(dashboardsByRef).sort()
+            .forEach(ref => {
               dashboardBuilder.push({
                 section: ref,
                 dashboards: dashboardsByRef[ref],

polygerrit-ui/app/elements/change-list/gr-change-list-item/gr-change-list-item.js

@@ -121,7 +121,8 @@
       } else {
         classes['u-gray-background'] = true;
       }
-      return Object.keys(classes).sort().join(' ');
+      return Object.keys(classes).sort()
+          .join(' ');
     }
 
     _computeLabelValue(change, labelName) {

polygerrit-ui/app/elements/change-list/gr-change-list-view/gr-change-list-view.js

@@ -163,10 +163,12 @@
       // in an async so that attachment to the DOM can take place first.
       this.async(() => this.fire('title-change', {title: this._query}));
 
-      this._getPreferences().then(prefs => {
+      this._getPreferences()
+          .then(prefs => {
             this._changesPerPage = prefs.changes_per_page;
             return this._getChanges();
-      }).then(changes => {
+          })
+          .then(changes => {
             changes = changes || [];
             if (this._query && changes.length === 1) {
               for (const query in LookupQueryPatterns) {

polygerrit-ui/app/elements/change-list/gr-dashboard-view/gr-dashboard-view.js

@@ -181,12 +181,14 @@
           .then(() => {
             this._maybeShowDraftsBanner();
             this.$.reporting.dashboardDisplayed();
-          }).catch(err => {
+          })
+          .catch(err => {
             this.fire('title-change', {
               title: title || this._computeTitle(user),
             });
             console.warn(err);
-          }).then(() => { this._loading = false; });
+          })
+          .then(() => { this._loading = false; });
     }
 
     /**
@@ -201,9 +203,9 @@
       if (!res) { return Promise.resolve(); }
 
       const queries = res.sections
-          .map(section => section.suffixForDashboard ?
+          .map(section => (section.suffixForDashboard ?
             section.query + ' ' + section.suffixForDashboard :
-            section.query);
+            section.query));
 
       if (checkForNewUser) {
         queries.push('owner:self limit:1');

polygerrit-ui/app/elements/change/gr-change-actions/gr-change-actions.js

@@ -474,12 +474,14 @@
       }
 
       this._loading = true;
-      return this._getRevisionActions().then(revisionActions => {
+      return this._getRevisionActions()
+          .then(revisionActions => {
             if (!revisionActions) { return; }
 
             this.revisionActions = this._updateRebaseAction(revisionActions);
             this._handleLoadingComplete();
-      }).catch(err => {
+          })
+          .catch(err => {
             this.fire('show-alert', {message: ERR_REVISION_ACTIONS});
             this._loading = false;
             throw err;
@@ -515,7 +517,8 @@
         label,
         __type: type,
         __key: ADDITIONAL_ACTION_KEY_PREFIX +
-            Math.random().toString(36).substr(2),
+            Math.random().toString(36)
+                .substr(2),
       };
       this.push('_additionalActions', action);
       return action.__key;

polygerrit-ui/app/elements/change/gr-change-metadata/gr-change-metadata.js

@@ -376,12 +376,15 @@
     _handleTopicRemoved(e) {
       const target = Polymer.dom(e).rootTarget;
       target.disabled = true;
-      this.$.restAPI.setChangeTopic(this.change._number, null).then(() => {
+      this.$.restAPI.setChangeTopic(this.change._number, null)
+          .then(() => {
             target.disabled = false;
             this.set(['change', 'topic'], '');
             this.dispatchEvent(
-            new CustomEvent('topic-changed', {bubbles: true, composed: true}));
+                new CustomEvent('topic-changed',
-      }).catch(err => {
+                    {bubbles: true, composed: true}));
+          })
+          .catch(err => {
             target.disabled = false;
             return;
           });
@@ -396,7 +399,8 @@
           .then(newHashtag => {
             target.disabled = false;
             this.set(['change', 'hashtags'], newHashtag);
-          }).catch(err => {
+          })
+          .catch(err => {
             target.disabled = false;
             return;
           });

polygerrit-ui/app/elements/change/gr-change-metadata/gr-change-metadata_test.html

@@ -736,8 +736,8 @@ limitations under the License.
         Gerrit.install(
             p => {
               plugin = p;
-              plugin.hook('change-metadata-item').getLastAttached().then(
+              plugin.hook('change-metadata-item').getLastAttached()
-                  el => hookEl = el);
+                  .then(el => hookEl = el);
             },
             '0.1',
             'http://some/plugins/url.html');

polygerrit-ui/app/elements/change/gr-change-view/gr-change-view.js

@@ -362,7 +362,8 @@
         this._setDiffViewMode();
       });
 
-      Gerrit.awaitPluginsLoaded().then(() => {
+      Gerrit.awaitPluginsLoaded()
+          .then(() => {
             this._dynamicTabHeaderEndpoints =
             Gerrit._endpoints.getDynamicEndpoints('change-view-tab-header');
             this._dynamicTabContentEndpoints =
@@ -371,7 +372,8 @@
             this._dynamicTabHeaderEndpoints.length) {
               console.warn('Different number of tab headers and tab content.');
             }
-      }).then(() => this._setPrimaryTab());
+          })
+          .then(() => this._setPrimaryTab());
 
       this.addEventListener('comment-save', this._handleCommentSave.bind(this));
       this.addEventListener('comment-refresh', this._reloadDrafts.bind(this));
@@ -413,11 +415,13 @@
     _setDiffViewMode(opt_reset) {
       if (!opt_reset && this.viewState.diffViewMode) { return; }
 
-      return this._getPreferences().then( prefs => {
+      return this._getPreferences()
+          .then( prefs => {
             if (!this.viewState.diffMode) {
               this.set('viewState.diffMode', prefs.default_diff_view);
             }
-      }).then(() => {
+          })
+          .then(() => {
             if (!this.viewState.diffMode) {
               this.set('viewState.diffMode', 'SIDE_BY_SIDE');
             }
@@ -497,7 +501,8 @@
             message);
         this._editingCommitMessage = false;
         this._reloadWindow();
-      }).catch(err => {
+      })
+          .catch(err => {
             this.$.commitMessageEditor.disabled = false;
           });
     }
@@ -689,7 +694,8 @@
     _handleMessageReply(e) {
       const msg = e.detail.message.message;
       const quoteStr = msg.split('\n').map(
-          line => { return '> ' + line; }).join('\n') + '\n\n';
+          line => { return '> ' + line; })
+          .join('\n') + '\n\n';
       this.$.replyDialog.quote = quoteStr;
       this._openReplyDialog(this.$.replyDialog.FocusTarget.BODY);
     }

polygerrit-ui/app/elements/change/gr-change-view/gr-change-view_test.html

@@ -1738,7 +1738,8 @@ limitations under the License.
         Gerrit.install(
             p => {
               plugin = p;
-              plugin.hook('change-view-integration').getLastAttached().then(
+              plugin.hook('change-view-integration').getLastAttached()
+                  .then(
                       el => hookEl = el);
             },
             '0.1',

polygerrit-ui/app/elements/change/gr-confirm-rebase-dialog/gr-confirm-rebase-dialog_test.html

@@ -153,12 +153,14 @@ limitations under the License.
 
       test('_getRecentChanges', () => {
         sandbox.spy(element, '_getRecentChanges');
-        return element._getRecentChanges().then(() => {
+        return element._getRecentChanges()
+            .then(() => {
               assert.deepEqual(element._recentChanges, recentChanges);
               assert.equal(element.$.restAPI.getChanges.callCount, 1);
               // When called a second time, should not re-request recent changes.
               element._getRecentChanges();
-        }).then(() => {
+            })
+            .then(() => {
               assert.equal(element._getRecentChanges.callCount, 2);
               assert.equal(element.$.restAPI.getChanges.callCount, 1);
             });

polygerrit-ui/app/elements/change/gr-file-list-header/gr-file-list-header.js

@@ -201,7 +201,8 @@
               this.set(['change', 'revisions', sha, 'description'], desc);
               this._patchsetDescription = desc;
             }
-          }).catch(err => {
+          })
+          .catch(err => {
             if (target) { target.disabled = false; }
             return;
           });

polygerrit-ui/app/elements/change/gr-file-list-header/gr-file-list-header_test.html

@@ -133,7 +133,8 @@ limitations under the License.
 
       // Simulate tapping the remove button, but call function directly so that
       // can determine what happens after the promise is resolved.
-      return element._handleDescriptionRemoved().then(() => {
+      return element._handleDescriptionRemoved()
+          .then(() => {
             // The API stub should be called with an empty string for the new
             // description.
             assert.equal(putDescStub.lastCall.args[2], '');
@@ -155,7 +156,8 @@ limitations under the License.
             // description.
             assert.equal(putDescStub.callCount, 2);
             assert.equal(putDescStub.lastCall.args[2], 'test2');
-      }).then(() => {
+          })
+          .then(() => {
             flushAsynchronousOperations();
             // The chip should be visible again, and the label hidden.
             assert.equal(element.change.revisions.rev1.description, 'test2');

polygerrit-ui/app/elements/change/gr-file-list/gr-file-list.js

@@ -297,9 +297,11 @@
       promises.push(this._getFiles().then(filesByPath => {
         this._filesByPath = filesByPath;
       }));
-      promises.push(this._getLoggedIn().then(loggedIn => {
+      promises.push(this._getLoggedIn()
+          .then(loggedIn => {
             return this._loggedIn = loggedIn;
-      }).then(loggedIn => {
+          })
+          .then(loggedIn => {
             if (!loggedIn) { return; }
 
             return this._getReviewedFiles().then(reviewed => {

polygerrit-ui/app/elements/change/gr-file-list/gr-file-list_test.html

@@ -686,7 +686,7 @@ limitations under the License.
       });
 
       test('r key toggles reviewed flag', () => {
-        const reducer = (accum, file) => file.isReviewed ? ++accum : accum;
+        const reducer = (accum, file) => (file.isReviewed ? ++accum : accum);
         const getNumReviewed = () => element._files.reduce(reducer, 0);
         flushAsynchronousOperations();
 
@@ -865,7 +865,8 @@ limitations under the License.
 
       // Click inside the diff. This should result in no additional calls to
       // _togglePathExpanded or _reviewFile.
-      Polymer.dom(element.root).querySelector('gr-diff-host').click();
+      Polymer.dom(element.root).querySelector('gr-diff-host')
+          .click();
       assert.isTrue(clickSpy.calledTwice);
       assert.isTrue(toggleExpandSpy.calledOnce);
       assert.isFalse(reviewStub.called);

polygerrit-ui/app/elements/change/gr-label-scores/gr-label-scores.js

@@ -97,7 +97,8 @@
 
       const labelsObj = labelRecord.base;
       if (!labelsObj) { return []; }
-      return Object.keys(labelsObj).sort().map(key => {
+      return Object.keys(labelsObj).sort()
+          .map(key => {
             return {
               name: key,
               value: this._getVoteForAccount(labelsObj, key, this.account),

polygerrit-ui/app/elements/change/gr-reply-dialog/gr-reply-dialog.js

@@ -474,7 +474,8 @@
       this.disabled = true;
 
       const errFn = this._handle400Error.bind(this);
-      return this._saveReview(obj, errFn).then(response => {
+      return this._saveReview(obj, errFn)
+          .then(response => {
             if (!response) {
               // Null or undefined response indicates that an error handler
               // took responsibility, so just return.
@@ -489,10 +490,12 @@
             this._includeComments = true;
             this.fire('send', null, {bubbles: false});
             return accountAdditions;
-      }).then(result => {
+          })
+          .then(result => {
             this.disabled = false;
             return result;
-      }).catch(err => {
+          })
+          .catch(err => {
             this.disabled = false;
             throw err;
           });

polygerrit-ui/app/elements/change/gr-reply-dialog/gr-reply-dialog_test.html

@@ -271,7 +271,8 @@ limitations under the License.
     test('getlabelValue when no score is selected', done => {
       flush(() => {
         element.$$('gr-label-scores')
-            .$$(`gr-label-score-row[name="Code-Review"]`).setSelectedValue(-1);
+            .$$(`gr-label-score-row[name="Code-Review"]`)
+            .setSelectedValue(-1);
         assert.strictEqual(element.getLabelValue('Verified'), ' 0');
         done();
       });
@@ -372,7 +373,8 @@ limitations under the License.
             element._pendingConfirmationDetails);
       }
 
-      observer.then(() => {
+      observer
+          .then(() => {
             assert.isTrue(isVisible(element.$.reviewerConfirmationOverlay));
             observer = overlayObserver('closed');
             const expected = 'Group name has 10 members';
@@ -386,7 +388,10 @@ limitations under the License.
 
             // We should be focused on account entry input.
             assert.isTrue(
-            isFocusInsideElement(element.$.reviewers.$.entry.$.input.$.input));
+                isFocusInsideElement(
+                    element.$.reviewers.$.entry.$.input.$.input
+                )
+            );
 
             // No reviewer/CC should have been added.
             assert.equal(element.$.ccs.additions().length, 0);
@@ -406,12 +411,14 @@ limitations under the License.
               };
             }
             return observer;
-      }).then(() => {
+          })
+          .then(() => {
             assert.isTrue(isVisible(element.$.reviewerConfirmationOverlay));
             observer = overlayObserver('closed');
             MockInteractions.tap(yesButton); // Confirm the group.
             return observer;
-      }).then(() => {
+          })
+          .then(() => {
             assert.isFalse(isVisible(element.$.reviewerConfirmationOverlay));
             const additions = cc ?
               element.$.ccs.additions() :
@@ -433,12 +440,19 @@ limitations under the License.
             // We should be focused on account entry input.
             if (cc) {
               assert.isTrue(
-              isFocusInsideElement(element.$.ccs.$.entry.$.input.$.input));
+                  isFocusInsideElement(
+                      element.$.ccs.$.entry.$.input.$.input
+                  )
+              );
             } else {
               assert.isTrue(
-              isFocusInsideElement(element.$.reviewers.$.entry.$.input.$.input));
+                  isFocusInsideElement(
+                      element.$.reviewers.$.entry.$.input.$.input
+                  )
+              );
             }
-      }).then(done);
+          })
+          .then(done);
     }
 
     test('cc confirmation', done => {
@@ -673,7 +687,8 @@ limitations under the License.
         // fail.
 
         element.$$('gr-label-scores').$$(
-            'gr-label-score-row[name="Verified"]').setSelectedValue(-1);
+            'gr-label-score-row[name="Verified"]')
+            .setSelectedValue(-1);
         MockInteractions.tap(element.$$('.send'));
       });
     });

polygerrit-ui/app/elements/change/gr-reviewer-list/gr-reviewer-list.js

@@ -249,7 +249,8 @@
             }
           }
         }
-      }).catch(err => {
+      })
+          .catch(err => {
             this.disabled = false;
             throw err;
           });

polygerrit-ui/app/elements/change/gr-upload-help-dialog/gr-upload-help-dialog.js

@@ -67,11 +67,13 @@
 
     attached() {
       super.attached();
-      this.$.restAPI.getLoggedIn().then(loggedIn => {
+      this.$.restAPI.getLoggedIn()
+          .then(loggedIn => {
             if (loggedIn) {
               return this.$.restAPI.getPreferences();
             }
-      }).then(prefs => {
+          })
+          .then(prefs => {
             if (prefs) {
               this._preferredDownloadCommand = prefs.download_command;
               this._preferredDownloadScheme = prefs.download_scheme;

polygerrit-ui/app/elements/core/gr-router/gr-router.js

@@ -634,7 +634,8 @@
      * @return {!string} Everything after the first '#' ("a#b#c" -> "b#c").
      */
     _getHashFromCanonicalPath(canonicalPath) {
-      return canonicalPath.split('#').slice(1).join('#');
+      return canonicalPath.split('#').slice(1)
+          .join('#');
     }
 
     _parseLineAddress(hash) {

polygerrit-ui/app/elements/core/gr-smart-search/gr-smart-search.js

@@ -135,7 +135,8 @@
           .then(accounts => {
             if (!accounts) { return []; }
             return this._mapAccountsHelper(accounts, predicate);
-          }).then(accounts => {
+          })
+          .then(accounts => {
             // When the expression supplied is a beginning substring of 'self',
             // add it as an autocomplete option.
             if (SELF_EXPRESSION.startsWith(expression)) {

polygerrit-ui/app/elements/core/gr-smart-search/gr-smart-search_test.html

@@ -71,10 +71,13 @@ limitations under the License.
           },
         ])
       );
-      element._fetchAccounts('owner', 's').then(s => {
+      element._fetchAccounts('owner', 's')
+          .then(s => {
             assert.deepEqual(s[0], {text: 'owner:fred@goog.co', label: 'fred'});
             assert.deepEqual(s[1], {text: 'owner:self'});
-      }).then(() => element._fetchAccounts('owner', 'selfs')).then(s => {
+          })
+          .then(() => element._fetchAccounts('owner', 'selfs'))
+          .then(s => {
             assert.notEqual(s[0], {text: 'owner:self'});
           });
     });
@@ -88,10 +91,13 @@ limitations under the License.
           },
         ])
       );
-      return element._fetchAccounts('owner', 'm').then(s => {
+      return element._fetchAccounts('owner', 'm')
+          .then(s => {
             assert.deepEqual(s[0], {text: 'owner:fred@goog.co', label: 'fred'});
             assert.deepEqual(s[1], {text: 'owner:me'});
-      }).then(() => element._fetchAccounts('owner', 'meme')).then(s => {
+          })
+          .then(() => element._fetchAccounts('owner', 'meme'))
+          .then(s => {
             assert.notEqual(s[0], {text: 'owner:me'});
           });
     });

polygerrit-ui/app/elements/diff/gr-apply-fix-dialog/gr-apply-fix-dialog.js

@@ -89,7 +89,8 @@
                 ({filepath: key, preview: res[key]}));
               this._currentPreviews = previews;
             }
-          }).catch(err => {
+          })
+          .catch(err => {
             this._close();
             this.dispatchEvent(new CustomEvent('show-error', {
               bubbles: true,
@@ -175,7 +176,8 @@
           this._currentFix.fix_id).then(res => {
         Gerrit.Nav.navigateToChange(this.change, 'edit', this._patchNum);
         this._close();
-      }).catch(err => {
+      })
+          .catch(err => {
             this.dispatchEvent(new CustomEvent('show-error', {
               bubbles: true,
               composed: true,

polygerrit-ui/app/elements/diff/gr-comment-api/gr-comment-api_test.html

@@ -131,13 +131,15 @@ limitations under the License.
 
       test('with loadAll first', done => {
         assert.isNotOk(element._changeComments);
-        element.loadAll().then(() => {
+        element.loadAll()
+            .then(() => {
               assert.isOk(element._changeComments);
               assert.equal(commentStub.callCount, 1);
               assert.equal(robotCommentStub.callCount, 1);
               assert.equal(draftStub.callCount, 1);
               return element.reloadDrafts();
-        }).then(() => {
+            })
+            .then(() => {
               assert.isOk(element._changeComments);
               assert.equal(commentStub.callCount, 1);
               assert.equal(robotCommentStub.callCount, 1);

polygerrit-ui/app/elements/diff/gr-diff-builder/gr-diff-builder_test.html

@@ -322,7 +322,8 @@ limitations under the License.
       const lineNumberEl = document.createElement('td');
 
       function slice(str, start, end) {
-        return Array.from(str).slice(start, end).join('');
+        return Array.from(str).slice(start, end)
+            .join('');
       }
 
       setup(() => {

polygerrit-ui/app/elements/diff/gr-diff-highlight/gr-diff-highlight_test.html

@@ -377,7 +377,8 @@ limitations under the License.
         const getRangeAtStub = sandbox.stub();
         getRangeAtStub
             .onFirstCall().returns(startRange)
-            .onSecondCall().returns(endRange);
+            .onSecondCall()
+            .returns(endRange);
         const selection = {
           rangeCount: 2,
           getRangeAt: getRangeAtStub,

polygerrit-ui/app/elements/diff/gr-diff-host/gr-diff-host.js

@@ -412,7 +412,8 @@
                         range.side);
                   });
                 });
-          }).catch(err => {
+          })
+          .catch(err => {
             console.warn('Loading coverage ranges failed: ', err);
           });
     }

polygerrit-ui/app/elements/diff/gr-diff-host/gr-diff-host_test.html

@@ -361,10 +361,12 @@ limitations under the License.
             Promise.resolve({content: []}));
         element.patchRange = {};
         let reloadComplete = false;
-        element.$.restAPI.getDiffPreferences().then(prefs => {
+        element.$.restAPI.getDiffPreferences()
+            .then(prefs => {
               element.prefs = prefs;
               return element.reload();
-        }).then(() => {
+            })
+            .then(() => {
               reloadComplete = true;
             });
         // Multiple cascading microtasks are scheduled.

polygerrit-ui/app/elements/diff/gr-diff-view/gr-diff-view.js

@@ -678,7 +678,8 @@
       promises.push(this._getChangeEdit(this._changeNum));
 
       this._loading = true;
-      return Promise.all(promises).then(r => {
+      return Promise.all(promises)
+          .then(r => {
             const edit = r[4];
             if (edit) {
               this.set('_change.revisions.' + edit.commit.commit, {
@@ -690,7 +691,8 @@
             this._loading = false;
             this.$.diffHost.comments = this._commentsForDiff;
             return this.$.diffHost.reload(true);
-      }).then(() => {
+          })
+          .then(() => {
             this.$.reporting.diffViewFullyLoaded();
             // If diff view displayed has not ended yet, it ends here.
             this.$.reporting.diffViewDisplayed();

polygerrit-ui/app/elements/diff/gr-patch-range-select/gr-patch-range-select_test.html

@@ -235,7 +235,8 @@ limitations under the License.
           // Should be recomputed for each available patch
           sandbox.stub(element, '_computeBaseDropdownContent');
           assert.equal(element._computeBaseDropdownContent.callCount, 0);
-          commentApiWrapper.loadComments().then().then(() => {
+          commentApiWrapper.loadComments().then()
+              .then(() => {
                 assert.equal(element._computeBaseDropdownContent.callCount, 1);
                 done();
               });
@@ -286,7 +287,8 @@ limitations under the License.
       // Should be recomputed for each available patch
       sandbox.stub(element, '_computePatchDropdownContent');
       assert.equal(element._computePatchDropdownContent.callCount, 0);
-      commentApiWrapper.loadComments().then().then(() => {
+      commentApiWrapper.loadComments().then()
+          .then(() => {
             done();
           });
     });

polygerrit-ui/app/elements/diff/gr-ranged-comment-layer/gr-ranged-comment-layer.js

@@ -208,7 +208,7 @@
             return range;
           })
           // Sort the ranges so that hovering highlights are on top.
-          .sort((a, b) => a.hovering && !b.hovering ? 1 : 0);
+          .sort((a, b) => (a.hovering && !b.hovering ? 1 : 0));
     }
   }
 

polygerrit-ui/app/elements/plugins/gr-endpoint-decorator/gr-endpoint-decorator.js

@@ -148,10 +148,12 @@
     ready() {
       super.ready();
       Gerrit._endpoints.onNewEndpoint(this.name, this._initModule.bind(this));
-      Gerrit.awaitPluginsLoaded().then(() => Promise.all(
+      Gerrit.awaitPluginsLoaded()
+          .then(() => Promise.all(
               Gerrit._endpoints.getPlugins(this.name).map(
                   pluginUrl => this._import(pluginUrl)))
-      ).then(() =>
+          )
+          .then(() =>
             Gerrit._endpoints
                 .getDetails(this.name)
                 .forEach(this._initModule, this)

polygerrit-ui/app/elements/plugins/gr-endpoint-decorator/gr-endpoint-decorator_test.html

@@ -96,7 +96,8 @@ limitations under the License.
       assert.equal(module['someparam'], 'barbar');
       return decorationHook.getLastAttached().then(element => {
         assert.strictEqual(element, module);
-      }).then(() => {
+      })
+          .then(() => {
             element.remove();
             assert.equal(decorationHook.getAllAttached().length, 0);
           });
@@ -109,9 +110,11 @@ limitations under the License.
           element => element.nodeName === 'OTHER-MODULE');
       assert.isOk(module);
       assert.equal(module['someparam'], 'foofoo');
-      return replacementHook.getLastAttached().then(element => {
+      return replacementHook.getLastAttached()
+          .then(element => {
             assert.strictEqual(element, module);
-      }).then(() => {
+          })
+          .then(() => {
             element.remove();
             assert.equal(replacementHook.getAllAttached().length, 0);
           });

polygerrit-ui/app/elements/plugins/gr-plugin-host/gr-plugin-host_test.html

@@ -81,7 +81,8 @@ limitations under the License.
 
     test('skip theme if preloaded', () => {
       sandbox.stub(Gerrit, '_isPluginPreloaded')
-          .withArgs('preloaded:gerrit-theme').returns(true);
+          .withArgs('preloaded:gerrit-theme')
+          .returns(true);
       sandbox.stub(Gerrit, '_loadPlugins');
       element.config = {
         default_theme: '/oof',

polygerrit-ui/app/elements/plugins/gr-settings-api/gr-settings-api.js

@@ -22,7 +22,8 @@
     this._title = '(no title)';
     // Generate default screen URL token, specific to plugin, and unique(ish).
     this._token =
-      plugin.getPluginName() + Math.random().toString(36).substr(5);
+      plugin.getPluginName() + Math.random().toString(36)
+          .substr(5);
     this.plugin = plugin;
   }
 

polygerrit-ui/app/elements/settings/gr-gpg-editor/gr-gpg-editor.js

@@ -96,7 +96,8 @@
             this.$.newKey.disabled = false;
             this._newKey = '';
             this.loadData();
-          }).catch(() => {
+          })
+          .catch(() => {
             this.$.addButton.disabled = false;
             this.$.newKey.disabled = false;
           });

polygerrit-ui/app/elements/settings/gr-menu-editor/gr-menu-editor_test.html

@@ -53,7 +53,8 @@ limitations under the License.
       const selector = 'tr:nth-child(' + (index + 1) + ') .move' +
           direction + 'Button';
       const button =
-          element.$$('tbody').querySelector(selector).$$('paper-button');
+          element.$$('tbody').querySelector(selector)
+              .$$('paper-button');
       MockInteractions.tap(button);
     }
 
@@ -147,14 +148,16 @@ limitations under the License.
 
       // Tap the delete button for the middle item.
       MockInteractions.tap(element.$$('tbody')
-          .querySelector('tr:nth-child(2) .remove-button').$$('paper-button'));
+          .querySelector('tr:nth-child(2) .remove-button')
+          .$$('paper-button'));
 
       assertMenuNamesEqual(element, ['first name', 'third name']);
 
       // Delete remaining items.
       for (let i = 0; i < 2; i++) {
         MockInteractions.tap(element.$$('tbody')
-            .querySelector('tr:first-child .remove-button').$$('paper-button'));
+            .querySelector('tr:first-child .remove-button')
+            .$$('paper-button'));
       }
       assertMenuNamesEqual(element, []);
 

polygerrit-ui/app/elements/settings/gr-registration-dialog/gr-registration-dialog_test.html

@@ -146,11 +146,13 @@ limitations under the License.
         assert.equal(account.email, 'email');
 
         // Save and verify new values are committed.
-        save().then(() => {
+        save()
+            .then(() => {
               assert.equal(account.name, 'new name');
               assert.equal(account.username, 'new username');
               assert.equal(account.email, 'email3');
-        }).then(done);
+            })
+            .then(done);
       });
     });
 

polygerrit-ui/app/elements/settings/gr-ssh-editor/gr-ssh-editor.js

@@ -91,7 +91,8 @@
             this.$.newKey.disabled = false;
             this._newKey = '';
             this.push('_keys', key);
-          }).catch(() => {
+          })
+          .catch(() => {
             this.$.addButton.disabled = false;
             this.$.newKey.disabled = false;
           });

polygerrit-ui/app/elements/shared/gr-account-list/gr-account-list_test.html

@@ -197,11 +197,13 @@ limitations under the License.
           return suggestion._account_id === accountId;
         };
 
-        element._getSuggestions().then(suggestions => {
+        element._getSuggestions()
+            .then(suggestions => {
               assert.deepEqual(suggestions,
                   [{name: originalSuggestions[0].email,
                     value: originalSuggestions[0]._account_id}]);
-        }).then(done);
+            })
+            .then(done);
       });
     });
 

polygerrit-ui/app/elements/shared/gr-comment/gr-comment.js

@@ -291,7 +291,8 @@
           this._fireSave();
           return obj;
         });
-      }).catch(err => {
+      })
+          .catch(err => {
             this.disabled = false;
             throw err;
           });
@@ -568,7 +569,8 @@
         }
 
         this._fireDiscard();
-      }).catch(err => {
+      })
+          .catch(err => {
             this.disabled = false;
             throw err;
           });

polygerrit-ui/app/elements/shared/gr-date-formatter/gr-date-formatter_test.html

@@ -62,7 +62,9 @@ limitations under the License.
         expectedTooltip, done) {
       // Normalize and convert the date to mimic server response.
       dateStr = normalizedDate(dateStr)
-          .toJSON().replace('T', ' ').slice(0, -1);
+          .toJSON()
+          .replace('T', ' ')
+          .slice(0, -1);
       sandbox.useFakeTimers(normalizedDate(nowStr).getTime());
       element.dateStr = dateStr;
       flush(() => {

polygerrit-ui/app/elements/shared/gr-js-api-interface/gr-api-utils.js

@@ -75,7 +75,8 @@
 
   // TODO(taoalpha): to be deprecated.
   function send(method, url, opt_callback, opt_payload) {
-    return getRestAPI().send(method, url, opt_payload).then(response => {
+    return getRestAPI().send(method, url, opt_payload)
+        .then(response => {
           if (response.status < 200 || response.status >= 300) {
             return response.text().then(text => {
               if (text) {
@@ -87,7 +88,8 @@
           } else {
             return getRestAPI().getResponseObject(response);
           }
-    }).then(response => {
+        })
+        .then(response => {
           if (opt_callback) {
             opt_callback(response);
           }

polygerrit-ui/app/elements/shared/gr-js-api-interface/gr-gerrit.js

@@ -109,7 +109,8 @@
 
   Gerrit.delete = function(url, opt_callback) {
     console.warn('.delete() is deprecated! Use plugin.restApi().delete()');
-    return getRestAPI().send('DELETE', url).then(response => {
+    return getRestAPI().send('DELETE', url)
+        .then(response => {
           if (response.status !== 204) {
             return response.text().then(text => {
               if (text) {

polygerrit-ui/app/elements/shared/gr-js-api-interface/gr-js-api-interface_test.html

@@ -329,7 +329,8 @@ limitations under the License.
       sandbox.stub(window, 'fetch', () => {
         return Promise.resolve({status: 204});
       });
-      plugin.restApi().getLoggedIn().then(loggedIn => {
+      plugin.restApi().getLoggedIn()
+          .then(loggedIn => {
             assert.isTrue(loggedIn);
             done();
           });

polygerrit-ui/app/elements/shared/gr-js-api-interface/gr-plugin-rest-api_test.html

@@ -121,7 +121,8 @@ limitations under the License.
           {status: 400, text() { return Promise.resolve('text'); }}));
       return instance.delete('/url').then(r => {
         throw new Error('Should not resolve');
-      }).catch(err => {
+      })
+          .catch(err => {
             assert.isTrue(sendStub.calledWith('DELETE', '/url'));
             assert.equal('text', err.message);
           });

polygerrit-ui/app/elements/shared/gr-label-info/gr-label-info.js

@@ -133,7 +133,8 @@
                 target.disabled = false;
                 if (!response.ok) { return; }
                 Gerrit.Nav.navigateToChange(this.change);
-              }).catch(err => {
+              })
+              .catch(err => {
                 target.disabled = false;
                 return;
               });

polygerrit-ui/app/elements/shared/gr-lib-loader/gr-lib-loader.js

@@ -59,7 +59,8 @@
         if (!this._hljsState.loading) {
           this._hljsState.loading = true;
           this._loadScript(this._getHLJSUrl())
-              .then(this._onHLJSLibLoaded.bind(this)).catch(reject);
+              .then(this._onHLJSLibLoaded.bind(this))
+              .catch(reject);
         }
 
         this._hljsState.callbacks.push(resolve);

polygerrit-ui/app/elements/shared/gr-rest-api-interface/gr-auth_test.html

@@ -315,12 +315,16 @@ limitations under the License.
         sandbox.stub(auth, '_isTokenValid');
         auth._isTokenValid
             .onFirstCall().returns(true)
-            .onSecondCall().returns(false)
+            .onSecondCall()
-            .onThirdCall().returns(true);
+            .returns(false)
-        auth.fetch('/url-one').then(() => {
+            .onThirdCall()
+            .returns(true);
+        auth.fetch('/url-one')
+            .then(() => {
               getToken.returns(Promise.resolve(makeToken('bzzbb')));
               return auth.fetch('/url-two');
-        }).then(() => {
+            })
+            .then(() => {
               const [[firstUrl], [secondUrl]] = fetch.args;
               assert.equal(firstUrl, '/a/url-one?access_token=zbaz');
               assert.equal(secondUrl, '/a/url-two?access_token=bzzbb');

polygerrit-ui/app/elements/shared/gr-rest-api-interface/gr-rest-api-interface.js

@@ -815,13 +815,15 @@
     }
 
     getIsAdmin() {
-      return this.getLoggedIn().then(isLoggedIn => {
+      return this.getLoggedIn()
+          .then(isLoggedIn => {
             if (isLoggedIn) {
               return this.getAccountCapabilities();
             } else {
               return Promise.resolve();
             }
-      }).then(capabilities => {
+          })
+          .then(capabilities => {
             return capabilities && capabilities.administrateServer;
           });
     }

polygerrit-ui/app/elements/shared/gr-rest-api-interface/gr-rest-api-interface_test.html

@@ -650,9 +650,11 @@ limitations under the License.
               ['Innocuous', 'hello'],
             ]},
           };
-          element._failForCreate200(Promise.resolve(result)).then(() => {
+          element._failForCreate200(Promise.resolve(result))
+              .then(() => {
                 assert.isTrue(false, 'Promise should not resolve');
-          }).catch(e => {
+              })
+              .catch(e => {
                 assert.isOk(e);
                 assert.include(e.message, 'Saving draft resulted in HTTP 200');
                 assert.include(e.message, 'hello');
@@ -667,9 +669,11 @@ limitations under the License.
             status: 201,
             headers: {entries: () => []},
           };
-          element._failForCreate200(Promise.resolve(result)).then(() => {
+          element._failForCreate200(Promise.resolve(result))
+              .then(() => {
                 done();
-          }).catch(e => {
+              })
+              .catch(e => {
                 assert.isTrue(false, 'Promise should not fail');
               });
         });

polygerrit-ui/app/elements/shared/gr-rest-api-interface/gr-rest-apis/gr-rest-api-helper.js

@@ -180,13 +180,15 @@
         fetchOptions: req.fetchOptions,
         anonymizedUrl: req.reportUrlAsIs ? urlWithParams : req.anonymizedUrl,
       };
-      return this.fetch(fetchReq).then(res => {
+      return this.fetch(fetchReq)
+          .then(res => {
             if (req.cancelCondition && req.cancelCondition()) {
               res.body.cancel();
               return;
             }
             return res;
-      }).catch(err => {
+          })
+          .catch(err => {
             if (req.errFn) {
               req.errFn.call(undefined, null, err);
             } else {
@@ -309,13 +311,15 @@
         return Promise.resolve(this._cache.get(req.url));
       }
       this._fetchPromisesCache.set(req.url,
-          this.fetchJSON(req).then(response => {
+          this.fetchJSON(req)
+              .then(response => {
                 if (response !== undefined) {
                   this._cache.set(req.url, response);
                 }
                 this._fetchPromisesCache.set(req.url, undefined);
                 return response;
-          }).catch(err => {
+              })
+              .catch(err => {
                 this._fetchPromisesCache.set(req.url, undefined);
                 throw err;
               })
@@ -360,7 +364,8 @@
           this.fire('server-error', {request: fetchReq, response});
         }
         return response;
-      }).catch(err => {
+      })
+          .catch(err => {
             this.fire('network-error', {error: err});
             if (req.errFn) {
               return req.errFn.call(undefined, null, err);

polygerrit-ui/app/elements/shared/gr-rest-api-interface/gr-reviewer-updates-parser.js

@@ -217,7 +217,9 @@
           const timestamp = util.parseDate(update.date).getTime() -
               GrReviewerUpdatesParser.MESSAGE_REVIEWERS_THRESHOLD_MILLIS;
           update.date = new Date(timestamp)
-              .toISOString().replace('T', ' ').replace('Z', '000000');
+              .toISOString()
+              .replace('T', ' ')
+              .replace('Z', '000000');
         }
         if (nextMessageDate && date > nextMessageDate) {
           break;

polygerrit-ui/app/elements/shared/gr-rest-api-interface/gr-reviewer-updates-parser_test.html

@@ -255,7 +255,9 @@ limitations under the License.
       const T0 = util.parseDate('2017-02-17 19:04:18.000000000').getTime();
       const tplus = delta => {
         return new Date(T0 + delta)
-            .toISOString().replace('T', ' ').replace('Z', '000000');
+            .toISOString()
+            .replace('T', ' ')
+            .replace('Z', '000000');
       };
       const change = {
         reviewer_updates: [{

polygerrit-ui/app/samples/repo-command.html

@@ -7,7 +7,8 @@
             if (repoName !== 'All-Projects') {
               return false;
             }
-          }).onTap(() => {
+          })
+          .onTap(() => {
             alert('Bork, bork!');
           });
 

polygerrit-ui/app/scripts/gr-reviewer-suggestions-provider/gr-reviewer-suggestions-provider_test.html

@@ -193,13 +193,16 @@ limitations under the License.
         });
 
         test('getSuggestions', done => {
-          provider.getSuggestions().then(reviewers => {
+          provider.getSuggestions()
+              .then(reviewers => {
                 // Default is no filtering.
                 assert.equal(reviewers.length, 6);
                 assert.deepEqual(reviewers,
                     [redundantSuggestion1, redundantSuggestion2,
-                  redundantSuggestion3, suggestion1, suggestion2, suggestion3]);
+                      redundantSuggestion3, suggestion1,
-          }).then(done);
+                      suggestion2, suggestion3]);
+              })
+              .then(done);
         });
 
         test('getSuggestions short circuits when logged out', () => {

polygerrit-ui/app/template_test_srcs/template_test.js

@@ -78,7 +78,8 @@ fs.readdir('./polygerrit-ui/temp/behaviors/', (err, data) => {
           if (joinedErrors) {
             process.exit(1);
           }
-        }).catch(e => {
+        })
+        .catch(e => {
           console.error(e);
           process.exit(1);
         });