opendev/gerrit
Code Issues Proposed changes

Remove unused ReviewDb from SuggestReviewers hierarchy

Browse Source 
Change-Id: I3ca85794b887237add8274008bfba534146d284e
This commit is contained in:
Dave Borowitz
2018-12-14 15:20:02 -08:00
parent ff4804173b
commit 815ddaa503
2 changed files with 2 additions and 11 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
java/com/google/gerrit/server/restapi/change/SuggestChangeReviewers.java
View File

@@ -20,7 +20,6 @@ import com.google.gerrit.extensions.restapi.AuthException;
import com.google.gerrit.extensions.restapi.BadRequestException;
import com.google.gerrit.extensions.restapi.RestReadView;
import com.google.gerrit.reviewdb.client.Account;
import com.google.gerrit.reviewdb.server.ReviewDb;
import com.google.gerrit.server.CurrentUser;
import com.google.gerrit.server.change.ChangeResource;
import com.google.gerrit.server.config.GerritServerConfig;
@@ -54,13 +53,12 @@ public class SuggestChangeReviewers extends SuggestReviewers
@Inject
SuggestChangeReviewers(
AccountVisibility av,
Provider<ReviewDb> dbProvider,
PermissionBackend permissionBackend,
Provider<CurrentUser> self,
@GerritServerConfig Config cfg,
ReviewersUtil reviewersUtil,
ProjectCache projectCache) {
super(av, dbProvider, cfg, reviewersUtil);
super(av, cfg, reviewersUtil);
this.permissionBackend = permissionBackend;
this.self = self;
this.projectCache = projectCache;

9
java/com/google/gerrit/server/restapi/change/SuggestReviewers.java
View File

@@ -18,13 +18,11 @@ import static com.google.gerrit.server.config.GerritConfigListenerHelper.acceptI
import com.google.common.flogger.FluentLogger;
import com.google.gerrit.extensions.common.AccountVisibility;
import com.google.gerrit.reviewdb.server.ReviewDb;
import com.google.gerrit.server.change.ReviewerAdder;
import com.google.gerrit.server.config.ConfigKey;
import com.google.gerrit.server.config.GerritConfigListener;
import com.google.gerrit.server.config.GerritServerConfig;
import com.google.inject.Inject;
import com.google.inject.Provider;
import org.eclipse.jgit.lib.Config;
import org.kohsuke.args4j.Option;
@@ -33,7 +31,6 @@ public class SuggestReviewers {
private static final int DEFAULT_MAX_SUGGESTED = 10;
protected final Provider<ReviewDb> dbProvider;
protected final ReviewersUtil reviewersUtil;
private final boolean suggestAccounts;
@@ -83,11 +80,7 @@ public class SuggestReviewers {
@Inject
public SuggestReviewers(
AccountVisibility av,
Provider<ReviewDb> dbProvider,
@GerritServerConfig Config cfg,
ReviewersUtil reviewersUtil) {
this.dbProvider = dbProvider;
AccountVisibility av, @GerritServerConfig Config cfg, ReviewersUtil reviewersUtil) {
this.reviewersUtil = reviewersUtil;
this.maxSuggestedReviewers =
cfg.getInt("suggest", "maxSuggestedReviewers", DEFAULT_MAX_SUGGESTED);