Remove unused ReviewDb from SuggestReviewers hierarchy

Change-Id: I3ca85794b887237add8274008bfba534146d284e
This commit is contained in:
Dave Borowitz
2018-12-14 15:20:02 -08:00
parent ff4804173b
commit 815ddaa503
2 changed files with 2 additions and 11 deletions

View File

@@ -20,7 +20,6 @@ import com.google.gerrit.extensions.restapi.AuthException;
import com.google.gerrit.extensions.restapi.BadRequestException; import com.google.gerrit.extensions.restapi.BadRequestException;
import com.google.gerrit.extensions.restapi.RestReadView; import com.google.gerrit.extensions.restapi.RestReadView;
import com.google.gerrit.reviewdb.client.Account; import com.google.gerrit.reviewdb.client.Account;
import com.google.gerrit.reviewdb.server.ReviewDb;
import com.google.gerrit.server.CurrentUser; import com.google.gerrit.server.CurrentUser;
import com.google.gerrit.server.change.ChangeResource; import com.google.gerrit.server.change.ChangeResource;
import com.google.gerrit.server.config.GerritServerConfig; import com.google.gerrit.server.config.GerritServerConfig;
@@ -54,13 +53,12 @@ public class SuggestChangeReviewers extends SuggestReviewers
@Inject @Inject
SuggestChangeReviewers( SuggestChangeReviewers(
AccountVisibility av, AccountVisibility av,
Provider<ReviewDb> dbProvider,
PermissionBackend permissionBackend, PermissionBackend permissionBackend,
Provider<CurrentUser> self, Provider<CurrentUser> self,
@GerritServerConfig Config cfg, @GerritServerConfig Config cfg,
ReviewersUtil reviewersUtil, ReviewersUtil reviewersUtil,
ProjectCache projectCache) { ProjectCache projectCache) {
super(av, dbProvider, cfg, reviewersUtil); super(av, cfg, reviewersUtil);
this.permissionBackend = permissionBackend; this.permissionBackend = permissionBackend;
this.self = self; this.self = self;
this.projectCache = projectCache; this.projectCache = projectCache;

View File

@@ -18,13 +18,11 @@ import static com.google.gerrit.server.config.GerritConfigListenerHelper.acceptI
import com.google.common.flogger.FluentLogger; import com.google.common.flogger.FluentLogger;
import com.google.gerrit.extensions.common.AccountVisibility; import com.google.gerrit.extensions.common.AccountVisibility;
import com.google.gerrit.reviewdb.server.ReviewDb;
import com.google.gerrit.server.change.ReviewerAdder; import com.google.gerrit.server.change.ReviewerAdder;
import com.google.gerrit.server.config.ConfigKey; import com.google.gerrit.server.config.ConfigKey;
import com.google.gerrit.server.config.GerritConfigListener; import com.google.gerrit.server.config.GerritConfigListener;
import com.google.gerrit.server.config.GerritServerConfig; import com.google.gerrit.server.config.GerritServerConfig;
import com.google.inject.Inject; import com.google.inject.Inject;
import com.google.inject.Provider;
import org.eclipse.jgit.lib.Config; import org.eclipse.jgit.lib.Config;
import org.kohsuke.args4j.Option; import org.kohsuke.args4j.Option;
@@ -33,7 +31,6 @@ public class SuggestReviewers {
private static final int DEFAULT_MAX_SUGGESTED = 10; private static final int DEFAULT_MAX_SUGGESTED = 10;
protected final Provider<ReviewDb> dbProvider;
protected final ReviewersUtil reviewersUtil; protected final ReviewersUtil reviewersUtil;
private final boolean suggestAccounts; private final boolean suggestAccounts;
@@ -83,11 +80,7 @@ public class SuggestReviewers {
@Inject @Inject
public SuggestReviewers( public SuggestReviewers(
AccountVisibility av, AccountVisibility av, @GerritServerConfig Config cfg, ReviewersUtil reviewersUtil) {
Provider<ReviewDb> dbProvider,
@GerritServerConfig Config cfg,
ReviewersUtil reviewersUtil) {
this.dbProvider = dbProvider;
this.reviewersUtil = reviewersUtil; this.reviewersUtil = reviewersUtil;
this.maxSuggestedReviewers = this.maxSuggestedReviewers =
cfg.getInt("suggest", "maxSuggestedReviewers", DEFAULT_MAX_SUGGESTED); cfg.getInt("suggest", "maxSuggestedReviewers", DEFAULT_MAX_SUGGESTED);