Use only Gerrit.install as a plugin loaded signal
Counting .html based plugin import as a load signal resulted in double counting. Change-Id: I63a096b3801b0dd889737ae847b29b0f6c8167f5
This commit is contained in:
@@ -93,7 +93,8 @@ limitations under the License.
|
|||||||
plugin: {
|
plugin: {
|
||||||
js_resource_paths: [],
|
js_resource_paths: [],
|
||||||
html_resource_paths: [
|
html_resource_paths: [
|
||||||
new URL('test/plugin.html', window.location.href).toString(),
|
new URL('test/plugin.html?' + Math.random(),
|
||||||
|
window.location.href).toString(),
|
||||||
],
|
],
|
||||||
},
|
},
|
||||||
};
|
};
|
||||||
|
|||||||
@@ -24,6 +24,8 @@ limitations under the License.
|
|||||||
<link rel="import" href="gr-endpoint-decorator.html">
|
<link rel="import" href="gr-endpoint-decorator.html">
|
||||||
<link rel="import" href="../gr-endpoint-param/gr-endpoint-param.html">
|
<link rel="import" href="../gr-endpoint-param/gr-endpoint-param.html">
|
||||||
|
|
||||||
|
<script>void(0);</script>
|
||||||
|
|
||||||
<test-fixture id="basic">
|
<test-fixture id="basic">
|
||||||
<template>
|
<template>
|
||||||
<gr-endpoint-decorator name="foo">
|
<gr-endpoint-decorator name="foo">
|
||||||
|
|||||||
@@ -47,12 +47,10 @@
|
|||||||
* States that it expects no more than 3 parameters, but that's not true.
|
* States that it expects no more than 3 parameters, but that's not true.
|
||||||
* @todo (beckysiegel) check Polymer annotations and submit change.
|
* @todo (beckysiegel) check Polymer annotations and submit change.
|
||||||
*/
|
*/
|
||||||
|
|
||||||
_importHtmlPlugins(plugins) {
|
_importHtmlPlugins(plugins) {
|
||||||
for (const url of plugins) {
|
for (const url of plugins) {
|
||||||
this.importHref(
|
this.importHref(
|
||||||
this._urlFor(url), Gerrit._pluginInstalled, Gerrit._pluginInstalled,
|
this._urlFor(url), null, Gerrit._pluginInstalled, true);
|
||||||
true);
|
|
||||||
}
|
}
|
||||||
},
|
},
|
||||||
|
|
||||||
|
|||||||
@@ -23,6 +23,8 @@ limitations under the License.
|
|||||||
<link rel="import" href="../../../test/common-test-setup.html"/>
|
<link rel="import" href="../../../test/common-test-setup.html"/>
|
||||||
<link rel="import" href="gr-plugin-host.html">
|
<link rel="import" href="gr-plugin-host.html">
|
||||||
|
|
||||||
|
<script>void(0);</script>
|
||||||
|
|
||||||
<test-fixture id="basic">
|
<test-fixture id="basic">
|
||||||
<template>
|
<template>
|
||||||
<gr-plugin-host></gr-plugin-host>
|
<gr-plugin-host></gr-plugin-host>
|
||||||
@@ -61,9 +63,9 @@ limitations under the License.
|
|||||||
plugin: {html_resource_paths: ['foo/bar', 'baz']},
|
plugin: {html_resource_paths: ['foo/bar', 'baz']},
|
||||||
};
|
};
|
||||||
assert.isTrue(element.importHref.calledWith(
|
assert.isTrue(element.importHref.calledWith(
|
||||||
'/foo/bar', Gerrit._pluginInstalled, Gerrit._pluginInstalled, true));
|
'/foo/bar', null, Gerrit._pluginInstalled, true));
|
||||||
assert.isTrue(element.importHref.calledWith(
|
assert.isTrue(element.importHref.calledWith(
|
||||||
'/baz', Gerrit._pluginInstalled, Gerrit._pluginInstalled, true));
|
'/baz', null, Gerrit._pluginInstalled, true));
|
||||||
});
|
});
|
||||||
|
|
||||||
test('imports relative html plugins from config with a base url', () => {
|
test('imports relative html plugins from config with a base url', () => {
|
||||||
@@ -71,11 +73,9 @@ limitations under the License.
|
|||||||
element.config = {
|
element.config = {
|
||||||
plugin: {html_resource_paths: ['foo/bar', 'baz']}};
|
plugin: {html_resource_paths: ['foo/bar', 'baz']}};
|
||||||
assert.isTrue(element.importHref.calledWith(
|
assert.isTrue(element.importHref.calledWith(
|
||||||
'/the-base/foo/bar', Gerrit._pluginInstalled, Gerrit._pluginInstalled,
|
'/the-base/foo/bar', null, Gerrit._pluginInstalled, true));
|
||||||
true));
|
|
||||||
assert.isTrue(element.importHref.calledWith(
|
assert.isTrue(element.importHref.calledWith(
|
||||||
'/the-base/baz', Gerrit._pluginInstalled, Gerrit._pluginInstalled,
|
'/the-base/baz', null, Gerrit._pluginInstalled, true));
|
||||||
true));
|
|
||||||
});
|
});
|
||||||
|
|
||||||
test('imports absolute html plugins from config', () => {
|
test('imports absolute html plugins from config', () => {
|
||||||
@@ -88,11 +88,9 @@ limitations under the License.
|
|||||||
},
|
},
|
||||||
};
|
};
|
||||||
assert.isTrue(element.importHref.calledWith(
|
assert.isTrue(element.importHref.calledWith(
|
||||||
'http://example.com/foo/bar', Gerrit._pluginInstalled,
|
'http://example.com/foo/bar', null, Gerrit._pluginInstalled, true));
|
||||||
Gerrit._pluginInstalled, true));
|
|
||||||
assert.isTrue(element.importHref.calledWith(
|
assert.isTrue(element.importHref.calledWith(
|
||||||
'https://example.com/baz', Gerrit._pluginInstalled,
|
'https://example.com/baz', null, Gerrit._pluginInstalled, true));
|
||||||
Gerrit._pluginInstalled, true));
|
|
||||||
});
|
});
|
||||||
|
|
||||||
test('adds js plugins from config to the body', () => {
|
test('adds js plugins from config to the body', () => {
|
||||||
@@ -139,9 +137,9 @@ limitations under the License.
|
|||||||
},
|
},
|
||||||
};
|
};
|
||||||
assert.isTrue(element.importHref.calledWith(
|
assert.isTrue(element.importHref.calledWith(
|
||||||
'/oof', Gerrit._pluginInstalled, Gerrit._pluginInstalled, true));
|
'/oof', null, Gerrit._pluginInstalled, true));
|
||||||
assert.isTrue(element.importHref.calledWith(
|
assert.isTrue(element.importHref.calledWith(
|
||||||
'/some', Gerrit._pluginInstalled, Gerrit._pluginInstalled, true));
|
'/some', null, Gerrit._pluginInstalled, true));
|
||||||
});
|
});
|
||||||
});
|
});
|
||||||
</script>
|
</script>
|
||||||
|
|||||||
Reference in New Issue
Block a user