diff --git a/gerrit-gwtui/src/main/java/com/google/gerrit/client/editor/EditScreen.java b/gerrit-gwtui/src/main/java/com/google/gerrit/client/editor/EditScreen.java index 670b5c8f2e..a546c62524 100644 --- a/gerrit-gwtui/src/main/java/com/google/gerrit/client/editor/EditScreen.java +++ b/gerrit-gwtui/src/main/java/com/google/gerrit/client/editor/EditScreen.java @@ -257,7 +257,20 @@ public class EditScreen extends Screen { return new Runnable() { @Override public void run() { - cm.execCommand("jumpToLine"); + String n = Window.prompt(EditConstants.I.gotoLineNumber(), ""); + if (n != null) { + try { + int line = Integer.parseInt(n); + line--; + if (line >= 0) { + cm.scrollToLine(line); + } + } catch (NumberFormatException e) { + // ignore non valid numbers + // We don't want to popup another ugly dialog just to say + // "The number you've provided is invalid, try again" + } + } } }; } diff --git a/lib/codemirror/cm.defs b/lib/codemirror/cm.defs index 39c4f096a6..967705889f 100644 --- a/lib/codemirror/cm.defs +++ b/lib/codemirror/cm.defs @@ -19,7 +19,6 @@ CM_ADDONS = [ 'edit/trailingspace.js', 'scroll/annotatescrollbar.js', 'scroll/simplescrollbars.js', - 'search/jump-to-line.js', 'search/matchesonscrollbar.js', 'search/searchcursor.js', 'search/search.js',