ES6ify /gr-change-table-behavior/*

Bug: Issue 6179
Change-Id: Ib3ea20a7450afd1752caeffe408e00b0699edf40

polygerrit-ui/app/behaviors/gr-change-table-behavior/gr-change-table-behavior.html

@@ -18,7 +18,7 @@ limitations under the License.
   'use strict';
 
   /** @polymerBehavior Gerrit.ChangeTableBehavior */
-  var ChangeTableBehavior = {
+  const ChangeTableBehavior = {
     properties: {
       columnNames: {
         type: Array,
@@ -32,21 +32,21 @@ limitations under the License.
           'Size',
         ],
         readOnly: true,
-      }
+      },
     },
 
     /**
      * Returns the complement to the given column array
      * @param {Array} columns
      */
-    getComplementColumns: function(columns) {
+    getComplementColumns(columns) {
-      return this.columnNames.filter(function(column) {
+      return this.columnNames.filter(column => {
-        return columns.indexOf(column) === -1;
+        return !columns.includes(column);
       });
     },
 
-    isColumnHidden: function(columnToCheck, columnsToDisplay) {
+    isColumnHidden(columnToCheck, columnsToDisplay) {
-      return columnsToDisplay.indexOf(columnToCheck) === -1;
+      return !columnsToDisplay.includes(columnToCheck);
     },
   };
 

polygerrit-ui/app/behaviors/gr-change-table-behavior/gr-change-table-behavior_test.html

@@ -39,11 +39,12 @@ limitations under the License.
 </test-fixture>
 
 <script>
-  suite('gr-change-table-behavior tests', function() {
+  suite('gr-change-table-behavior tests', () => {
-    var element;
+    let element;
-    var overlay;
+    // eslint-disable-next-line no-unused-vars
+    let overlay;
 
-    suiteSetup(function() {
+    suiteSetup(() => {
       // Define a Polymer element that uses this behavior.
       Polymer({
         is: 'test-element',
@@ -51,13 +52,13 @@ limitations under the License.
       });
     });
 
-    setup(function() {
+    setup(() => {
       element = fixture('basic');
       overlay = fixture('within-overlay');
     });
 
-    test('getComplementColumns', function() {
+    test('getComplementColumns', () => {
-      var columns = [
+      let columns = [
         'Subject',
         'Status',
         'Owner',
@@ -79,9 +80,9 @@ limitations under the License.
           ['Owner', 'Updated']);
     });
 
-    test('isColumnHidden', function() {
+    test('isColumnHidden', () => {
-      var columnToCheck = 'Project';
+      const columnToCheck = 'Project';
-      var columnsToDisplay = [
+      let columnsToDisplay = [
         'Subject',
         'Status',
         'Owner',
@@ -92,7 +93,7 @@ limitations under the License.
       ];
       assert.isFalse(element.isColumnHidden(columnToCheck, columnsToDisplay));
 
-      var columnsToDisplay = [
+      columnsToDisplay = [
         'Subject',
         'Status',
         'Owner',