From 830cf983e7ff2d90bf74b0b71ad06cc53b9f5bb3 Mon Sep 17 00:00:00 2001 From: Doug Kelly Date: Sat, 5 Dec 2015 10:01:34 -0600 Subject: [PATCH] Improve visibility of comments on dark themes Comments when using dark themes were originally improved by Ie8b624b4201de696e6cfa282dca5f6000b1a901d, however due to a refactor, this CSS no longer worked in 2.11+. Update the CSS accordingly, and add a few more improvements for line numbers and range comments when using dark themes. Bug: Issue 3714 Change-Id: I8c4c69cbd8e988861a8022b6c906f98c54314b40 --- .../google/gerrit/client/diff/CommentBox.css | 25 +++++++++++++------ 1 file changed, 17 insertions(+), 8 deletions(-) diff --git a/gerrit-gwtui/src/main/java/com/google/gerrit/client/diff/CommentBox.css b/gerrit-gwtui/src/main/java/com/google/gerrit/client/diff/CommentBox.css index 441af22cc1..e72c8406e6 100644 --- a/gerrit-gwtui/src/main/java/com/google/gerrit/client/diff/CommentBox.css +++ b/gerrit-gwtui/src/main/java/com/google/gerrit/client/diff/CommentBox.css @@ -17,24 +17,33 @@ @external .cm-s-night; @external .cm-s-twilight; @external .com-google-gerrit-client-diff-PublishedBox_BinderImpl_GenCss_style-name; -@external .com-google-gerrit-client-diff-Resources-Style-message; -@external .com-google-gerrit-client-diff-Resources-Style-date; +@external .com-google-gerrit-client-diff-CommentBox-Style-message; +@external .com-google-gerrit-client-diff-CommentBox-Style-date; +@external .com-google-gerrit-client-diff-DiffTable_BinderImpl_GenCss_style-range; @external .com-google-gerrit-client-diff-DiffTable_BinderImpl_GenCss_style-rangeHighlight; +@external .net-codemirror-lib-CodeMirror-Style-activeLine; +@external .CodeMirror-linenumber; .cm-s-midnight .com-google-gerrit-client-diff-PublishedBox_BinderImpl_GenCss_style-name { color: black } -.cm-s-midnight .com-google-gerrit-client-diff-Resources-Style-message { color: black } -.cm-s-midnight .com-google-gerrit-client-diff-Resources-Style-date { color: black } +.cm-s-midnight .com-google-gerrit-client-diff-CommentBox-Style-message { color: black } +.cm-s-midnight .com-google-gerrit-client-diff-CommentBox-Style-date { color: black } +.cm-s-midnight .com-google-gerrit-client-diff-DiffTable_BinderImpl_GenCss_style-range { color: #777 } .cm-s-midnight .com-google-gerrit-client-diff-DiffTable_BinderImpl_GenCss_style-rangeHighlight { color: #777 } +.cm-s-midnight .net-codemirror-lib-CodeMirror-Style-activeLine .CodeMirror-linenumber { color: black } .cm-s-night .com-google-gerrit-client-diff-PublishedBox_BinderImpl_GenCss_style-name { color: black } -.cm-s-night .com-google-gerrit-client-diff-Resources-Style-message { color: black } -.cm-s-night .com-google-gerrit-client-diff-Resources-Style-date { color: black } +.cm-s-night .com-google-gerrit-client-diff-CommentBox-Style-message { color: black } +.cm-s-night .com-google-gerrit-client-diff-CommentBox-Style-date { color: black } +.cm-s-night .com-google-gerrit-client-diff-DiffTable_BinderImpl_GenCss_style-range { color: #777 } .cm-s-night .com-google-gerrit-client-diff-DiffTable_BinderImpl_GenCss_style-rangeHighlight { color: #777 } +.cm-s-night .net-codemirror-lib-CodeMirror-Style-activeLine .CodeMirror-linenumber { color: black } .cm-s-twilight .com-google-gerrit-client-diff-PublishedBox_BinderImpl_GenCss_style-name { color: black } -.cm-s-twilight .com-google-gerrit-client-diff-Resources-Style-message { color: black } -.cm-s-twilight .com-google-gerrit-client-diff-Resources-Style-date { color: black } +.cm-s-twilight .com-google-gerrit-client-diff-CommentBox-Style-message { color: black } +.cm-s-twilight .com-google-gerrit-client-diff-CommentBox-Style-date { color: black } +.cm-s-twilight .com-google-gerrit-client-diff-DiffTable_BinderImpl_GenCss_style-range { color: #777 } .cm-s-twilight .com-google-gerrit-client-diff-DiffTable_BinderImpl_GenCss_style-rangeHighlight { color: #777 } +.cm-s-twilight .net-codemirror-lib-CodeMirror-Style-activeLine .CodeMirror-linenumber { color: black } .commentWidgets { max-width: 650px;