opendev/gerrit
Code Issues Proposed changes

set-account command: Do not close ReviewDb that was injected

Browse Source 
The ReviewDb only needs to be closed if it was created by
schemaFactory.open() but then the closing should be done in a finally
block.

Change-Id: Ia0082321455cd383e90f5333680ade5a52331d3a
Signed-off-by: Edwin Kempin <edwin.kempin@sap.com>
This commit is contained in:
Edwin Kempin
2012-09-13 09:43:11 +02:00
parent eaac316bf3
commit 83ed144108
1 changed files with 0 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
gerrit-sshd/src/main/java/com/google/gerrit/sshd/commands/SetAccountCommand.java
View File

@@ -175,8 +175,6 @@ final class SetAccountCommand extends BaseCommand {
if (sshKeysUpdated) {
sshKeyCache.evict(account.getUserName());
}
db.close();
}
private void addSshKeys(final List<String> keys, final Account account)