opendev/gerrit
Code Issues Proposed changes

Flip the defaults of the attention and assignee flags

Browse Source 
By default the attention set becomes enabled and the assignee feature
becomes disabled.

Change-Id: Ic55a731eb5136306dd14c6bad80e1e160185793a
(cherry picked from commit 4427d43734)
This commit is contained in:
Ben Rohlfs
2020-10-28 09:14:10 +01:00
committed by Gal Paikin
parent 7086aae782
commit 848ad1a813
4 changed files with 9 additions and 9 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
Documentation/config-gerrit.txt
View File

@@ -1284,14 +1284,14 @@ The default is false.
If set to true, then all UI features for using and interacting with the If set to true, then all UI features for using and interacting with the
attention set are enabled. attention set are enabled.
+ +
The default is false for now, but will be changed to true in Q2 2020. The default is true.
[[change.enableAssignee]]change.enableAssignee:: [[change.enableAssignee]]change.enableAssignee::
+ +
If set to true, then all UI features for using and interacting with the If set to true, then all UI features for using and interacting with the
assignee are enabled. assignee are enabled.
+ +
The default is true for now, but will be changed to false in Q2 2020. The default is false.
[[change.largeChange]]change.largeChange:: [[change.largeChange]]change.largeChange::
+ +

7
Documentation/user-attention-set.txt
View File

@@ -156,10 +156,9 @@ been replaced by the attention set.
=== For Gerrit Admins === For Gerrit Admins
The Attention Set will be part of the upcoming 3.3 release (due late 2020). The Attention Set will be part of the upcoming 3.3 release (due late 2020). It
We are testing it on `googlesource.com` right now. If you build your Gerrit from is enabled by default, but you can disable it by setting
master, you can enable it using link:config-gerrit.html#change.enableAttentionSet[enableAttentionSet] to false.
link:config-gerrit.html#change.enableAttentionSet[enableAttentionSet].
=== Important note for all host owners, project owners, and bot owners === Important note for all host owners, project owners, and bot owners

2
java/com/google/gerrit/server/mail/EmailSettings.java
View File

@@ -61,6 +61,6 @@ public class EmailSettings {
TimeUnit.MILLISECONDS.convert(60, TimeUnit.SECONDS), TimeUnit.MILLISECONDS.convert(60, TimeUnit.SECONDS),
TimeUnit.MILLISECONDS); TimeUnit.MILLISECONDS);
sendNewPatchsetEmails = cfg.getBoolean("change", null, "sendNewPatchsetEmails", true); sendNewPatchsetEmails = cfg.getBoolean("change", null, "sendNewPatchsetEmails", true);
isAttentionSetEnabled = cfg.getBoolean("change", null, "enableAttentionSet", false); isAttentionSetEnabled = cfg.getBoolean("change", null, "enableAttentionSet", true);
} }
} }

5
java/com/google/gerrit/server/restapi/config/GetServerInfo.java
View File

@@ -238,8 +238,9 @@ public class GetServerInfo implements RestReadView<ConfigResource> {
info.mergeabilityComputationBehavior = info.mergeabilityComputationBehavior =
MergeabilityComputationBehavior.fromConfig(config).name(); MergeabilityComputationBehavior.fromConfig(config).name();
info.enableAttentionSet = info.enableAttentionSet =
toBoolean(this.config.getBoolean("change", null, "enableAttentionSet", false)); toBoolean(this.config.getBoolean("change", null, "enableAttentionSet", true));
info.enableAssignee = toBoolean(this.config.getBoolean("change", null, "enableAssignee", true)); info.enableAssignee =
toBoolean(this.config.getBoolean("change", null, "enableAssignee", false));
return info; return info;
} }