opendev/gerrit
Code Issues Proposed changes

Merge "Use placeholder in change list size col"

Browse Source
This commit is contained in:
Kasper Nilsson
2018-03-08 22:49:27 +00:00
committed by Gerrit Code Review
parent 6658205a55 ffc011ce16
commit 84da8dc4ba
3 changed files with 12 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

7
polygerrit-ui/app/elements/change-list/gr-change-list-item/gr-change-list-item.html
View File

@@ -212,7 +212,12 @@ limitations under the License.
<gr-tooltip-content <gr-tooltip-content
has-tooltip has-tooltip
title="[[_computeSizeTooltip(change)]]"> title="[[_computeSizeTooltip(change)]]">
<span>[[_computeChangeSize(change)]]</span> <template is="dom-if" if="[[_changeSize]]">
<span>[[_changeSize]]</span>
</template>
<template is="dom-if" if="[[!_changeSize]]">
<span class="placeholder">--</span>
</template>
</gr-tooltip-content> </gr-tooltip-content>
</td> </td>
<template is="dom-repeat" items="[[labelNames]]" as="labelName"> <template is="dom-repeat" items="[[labelNames]]" as="labelName">

6
polygerrit-ui/app/elements/change-list/gr-change-list-item/gr-change-list-item.js
View File

@@ -45,6 +45,10 @@
value: false, value: false,
}, },
showNumber: Boolean, showNumber: Boolean,
_changeSize: {
type: String,
computed: '_computeChangeSize(change)',
},
}, },
behaviors: [ behaviors: [
@@ -153,7 +157,7 @@
_computeChangeSize(change) { _computeChangeSize(change) {
const delta = change.insertions + change.deletions; const delta = change.insertions + change.deletions;
if (isNaN(delta) || delta === 0) { if (isNaN(delta) || delta === 0) {
return '🤷'; // Unknown return null; // Unknown
} }
if (delta < CHANGE_SIZE.XS) { if (delta < CHANGE_SIZE.XS) {
return 'XS'; return 'XS';

2
polygerrit-ui/app/elements/change-list/gr-change-list-item/gr-change-list-item_test.html
View File

@@ -226,7 +226,7 @@ limitations under the License.
assert.equal(element._computeChangeSize({ assert.equal(element._computeChangeSize({
insertions: 'foo', insertions: 'foo',
deletions: 'bar', deletions: 'bar',
}), '🤷'); }), null);
assert.equal(element._computeChangeSize({ assert.equal(element._computeChangeSize({
insertions: 1, insertions: 1,
deletions: 1, deletions: 1,