opendev/gerrit
Code Issues Proposed changes

Remove unnecessary annotations from reindex test classes

Browse Source 
AbstractReindexTests doesn't need the @Ignore annotation because it isn't
included in the sources glob for the test rule.

The concrete *IT classes don't need the @NoHttpd annotation because it's
already on the AbstractReindexTests class.

Change-Id: Ib3cc3270486bac0b67604af8e97bd92798655af7
This commit is contained in:
David Pursehouse 2018-06-05 17:08:49 +09:00
parent 000872edcd
commit 852e5ac7ac
3 changed files with 0 additions and 7 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
gerrit-acceptance-tests/src/test/java/com/google/gerrit/acceptance/pgm/AbstractReindexTests.java
View File

@ -26,11 +26,9 @@ import com.google.gerrit.extensions.common.ChangeInput;
import com.google.gerrit.reviewdb.client.Project;
import com.google.inject.Injector;
import java.nio.file.Files;
import org.junit.Ignore;
import org.junit.Test;
@NoHttpd
@Ignore
public abstract class AbstractReindexTests extends StandaloneSiteTest {
/** @param injector injector */
public abstract void configureIndex(Injector injector) throws Exception;

2
gerrit-acceptance-tests/src/test/java/com/google/gerrit/acceptance/pgm/ElasticReindexIT.java
View File

@ -14,7 +14,6 @@
package com.google.gerrit.acceptance.pgm;
import com.google.gerrit.acceptance.NoHttpd;
import com.google.gerrit.elasticsearch.ElasticVersion;
import com.google.gerrit.elasticsearch.testing.ElasticContainer;
import com.google.gerrit.elasticsearch.testing.ElasticTestUtils;
@ -25,7 +24,6 @@ import java.util.UUID;
import org.eclipse.jgit.lib.Config;
import org.junit.After;
@NoHttpd
public class ElasticReindexIT extends AbstractReindexTests {
private static ElasticContainer<?> container;

3
gerrit-acceptance-tests/src/test/java/com/google/gerrit/acceptance/pgm/ReindexIT.java
View File

@ -14,12 +14,9 @@
package com.google.gerrit.acceptance.pgm;
import com.google.gerrit.acceptance.NoHttpd;
import com.google.inject.Injector;
@NoHttpd
public class ReindexIT extends AbstractReindexTests {
@Override
public void configureIndex(Injector injector) throws Exception {}
}