opendev/gerrit
Code Issues Proposed changes

Use page/page.js instead of page/page.mjs

Browse Source 
This change is required for typescript convertion. Typescript can't
import mjs files.

Change-Id: Iad7552a30fb80bc513a23a076b0a38bdf35ee4b8
This commit is contained in:
Dmitrii Filippov
2020-08-13 11:41:15 +02:00
parent 7cc4ea0e08
commit 85b48915f9
18 changed files with 86 additions and 16 deletions
Download Patch File Download Diff File Expand all files Collapse all files

13
polygerrit-ui/server.go
View File

@@ -191,6 +191,19 @@ func handleSrcRequest(compiledSrcPath string, dirListingMux *http.ServeMux, writ
moduleImportRegexp = regexp.MustCompile("(?m)^(import.*)'([^/.].*)';$")
data = moduleImportRegexp.ReplaceAll(data, []byte("$1 '/node_modules/$2';"))
if strings.HasSuffix(normalizedContentPath, "/node_modules/page/page.js") {
// Can't import page.js directly, because this is undefined.
// Replace it with window
// The same replace exists in karma.conf.js
// Rollup makes this replacement automatically
pageJsRegexp := regexp.MustCompile(`(?m)^}\(this, \(function \(\) { 'use strict';$`)
newData := pageJsRegexp.ReplaceAll(data, []byte("}(window, (function () { 'use strict';"))
if len(newData) == len(data) {
log.Fatal("The page.js was updated. Please update regexp/replace accordingly")
}
data = newData
}
writer.Header().Set("Content-Type", "application/javascript")
} else if strings.HasSuffix(normalizedContentPath, ".css") {
writer.Header().Set("Content-Type", "text/css")