opendev/gerrit
Code Issues Proposed changes

Bazel: Replace deprecated dependency mode LOOSE with PRUNE_LEGACY

Browse Source 
This fixes this warning in closure_js_binary rule:

  dependency_mode=LOOSE is deprecated and will be removed soon;
  prefer to use its equivalent PRUNE_LEGACY

that was added in this PR: [1].

[1] https://github.com/bazelbuild/rules_closure/pull/444

Change-Id: I648f581a8f585402543b97ce7a7ef056ca298c3e
This commit is contained in:
David Ostrovsky
2019-12-24 14:47:17 +01:00
parent a10aa5e822
commit 85eb97817c
2 changed files with 2 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files

1
polygerrit-ui/app/rules.bzl
View File

@@ -20,6 +20,7 @@ def polygerrit_bundle(name, srcs, outs, app):
], ],
language = "ECMASCRIPT5", language = "ECMASCRIPT5",
deps = [name + "_closure_lib"], deps = [name + "_closure_lib"],
dependency_mode = "PRUNE_LEGACY",
) )
# TODO(davido): Remove JSC_REFERENCE_BEFORE_DECLARE when this is fixed upstream: # TODO(davido): Remove JSC_REFERENCE_BEFORE_DECLARE when this is fixed upstream:

1
tools/bzl/js.bzl
View File

@@ -484,6 +484,7 @@ def polygerrit_plugin(name, app, srcs = [], deps = [], assets = None, plugin_nam
deps = [ deps = [
name + "_closure_lib", name + "_closure_lib",
], ],
dependency_mode = "PRUNE_LEGACY",
) )
if html_plugin: if html_plugin: