opendev/gerrit
Code Issues Proposed changes

SideBySide2: Move "No Differences" to right side of header

Browse Source 
On long project and file path names the path information was drawing
overlapped on top of the centered "No Differences" warning. Move
this warning to the far right edge of the header, next to the
navigation buttons.

Drop the font-family from the navigation panel, the widgets are drawn
as image icons and no longer depend on a font to render Unicode
arrows on all platforms. Dropping the font-family rule allows the
"No Differences" text to use the same family as the rest of the page.

Make "No Differences" bold and offset from the arrow group slightly
so it stands out more.

The side gutter is only given 10px by DiffTable.ui.xml, so move
the entire arrow group so the right edge is on the edge of the CM3
instance. The old position was simply wrong and the extra few pixels
can be made available to an incredibly long path name.

Change-Id: I38a312c8523975f9c44578f33891f9362a900c4c
This commit is contained in:
Shawn Pearce
2013-12-26 16:31:23 -08:00
parent 62b1421c2f
commit 86b8795437
1 changed files with 7 additions and 9 deletions
Download Patch File Download Diff File Expand all files Collapse all files

16
gerrit-gwtui/src/main/java/com/google/gerrit/client/diff/Header.ui.xml
View File

@@ -37,14 +37,16 @@ limitations under the License.
.navigation {
position: absolute;
top: 0;
right: 15px;
right: 10px;
height: 16px;
font-family: Arial Unicode MS, sans-serif;
line-height: 16px;
}
.nodiff {
position: absolute;
left: literal("calc(50% - 30px)");
white-space: nowrap;
color: #B00000;
vertical-align: top;
font-weight: bold;
margin-right: 1em;
}
.preferences {
cursor: pointer;
@@ -57,12 +59,8 @@ limitations under the License.
<ui:attribute name='title'/>
</g:CheckBox>
<span class='{style.path}'><span ui:field='project'/> / <span ui:field='filePath'/></span>
<span ui:field='noDiff' class='{style.nodiff}'>
<ui:msg>No Differences</ui:msg>
</span>
<div class='{style.navigation}'>
<span ui:field='noDiff' class='{style.nodiff}'><ui:msg>No Differences</ui:msg></span>
<x:InlineHyperlink ui:field='prev' styleName='{res.style.go_prev}'/>
<x:InlineHyperlink ui:field='up'
styleName='{res.style.go_up}'