opendev/gerrit
Code Issues Proposed changes

Only cache active accounts for reviewer suggestions

Browse Source 
Inactive accounts are filtered out of matching results
so there is no value in caching inactive accounts.

Change-Id: Ifeed9dc19e9d8478b86dcbe2a3794ee31d5d1997
This commit is contained in:
Shawn Pearce
2014-12-26 20:31:46 -05:00
parent 633ad26294
commit 86f0aae8e4
1 changed files with 10 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

11
gerrit-server/src/main/java/com/google/gerrit/server/change/ReviewerSuggestionCache.java
View File

@@ -14,10 +14,12 @@
package com.google.gerrit.server.change;
import com.google.common.base.Predicate;
import com.google.common.cache.CacheBuilder;
import com.google.common.cache.CacheLoader;
import com.google.common.cache.LoadingCache;
import com.google.common.collect.ImmutableList;
import com.google.common.collect.Iterables;
import com.google.gerrit.reviewdb.client.Account;
import com.google.gerrit.reviewdb.server.ReviewDb;
import com.google.inject.Inject;
@@ -50,7 +52,14 @@ public class ReviewerSuggestionCache {
.build(new CacheLoader<Boolean, List<Account>>() {
@Override
public List<Account> load(Boolean key) throws Exception {
return ImmutableList.copyOf(dbProvider.get().accounts().all());
return ImmutableList.copyOf(Iterables.filter(
dbProvider.get().accounts().all(),
new Predicate<Account>() {
@Override
public boolean apply(Account in) {
return in.isActive();
}
}));
}
});
}