opendev/gerrit
Code Issues Proposed changes

Merge "ReceiveCommits: Don't instantiate BranchCommitValidator repeatedly" into stable-2.16

Browse Source
This commit is contained in:
David Pursehouse
2019-06-27 08:16:07 +00:00
committed by Gerrit Code Review
parent c988da6b55 1014b5afa8
commit 87b2b35d16
1 changed files with 1 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
java/com/google/gerrit/server/git/receive/ReceiveCommits.java
View File

@@ -3033,6 +3033,7 @@ class ReceiveCommits {
} }
} }
BranchCommitValidator validator = commitValidatorFactory.create(projectState, branch, user);
RevWalk walk = receivePack.getRevWalk(); RevWalk walk = receivePack.getRevWalk();
walk.reset(); walk.reset();
walk.sort(RevSort.NONE); walk.sort(RevSort.NONE);
@@ -3059,7 +3060,6 @@ class ReceiveCommits {
continue; continue;
} }
BranchCommitValidator validator = commitValidatorFactory.create(projectState, branch, user);
if (!validator.validCommit( if (!validator.validCommit(
walk.getObjectReader(), cmd, c, false, messages, rejectCommits, null, skipValidation)) { walk.getObjectReader(), cmd, c, false, messages, rejectCommits, null, skipValidation)) {
break; break;