opendev/gerrit
Code Issues Proposed changes

Remove unused ApprovalsUtil from ChangeControl

Browse Source 
Change-Id: I9176c6ff29d5d9d7dc8570086df0b97f20ddee12
This commit is contained in:
Dave Borowitz
2014-04-10 13:25:02 -04:00
parent 8f92cb9b2b
commit 87c760e29f
1 changed files with 2 additions and 7 deletions
Download Patch File Download Diff File Expand all files Collapse all files

9
gerrit-server/src/main/java/com/google/gerrit/server/project/ChangeControl.java
View File

@@ -29,7 +29,6 @@ import com.google.gerrit.reviewdb.client.PatchSet;
import com.google.gerrit.reviewdb.client.PatchSetApproval; import com.google.gerrit.reviewdb.client.PatchSetApproval;
import com.google.gerrit.reviewdb.client.Project; import com.google.gerrit.reviewdb.client.Project;
import com.google.gerrit.reviewdb.server.ReviewDb; import com.google.gerrit.reviewdb.server.ReviewDb;
import com.google.gerrit.server.ApprovalsUtil;
import com.google.gerrit.server.CurrentUser; import com.google.gerrit.server.CurrentUser;
import com.google.gerrit.server.IdentifiedUser; import com.google.gerrit.server.IdentifiedUser;
import com.google.gerrit.server.notedb.ChangeNotes; import com.google.gerrit.server.notedb.ChangeNotes;
@@ -189,29 +188,25 @@ public class ChangeControl {
} }
} }
private final ApprovalsUtil approvalsUtil;
private final ChangeData.Factory changeDataFactory; private final ChangeData.Factory changeDataFactory;
private final RefControl refControl; private final RefControl refControl;
private final ChangeNotes notes; private final ChangeNotes notes;
@AssistedInject @AssistedInject
ChangeControl( ChangeControl(
ApprovalsUtil approvalsUtil,
ChangeData.Factory changeDataFactory, ChangeData.Factory changeDataFactory,
ChangeNotes.Factory notesFactory, ChangeNotes.Factory notesFactory,
@Assisted RefControl refControl, @Assisted RefControl refControl,
@Assisted Change change) { @Assisted Change change) {
this(approvalsUtil, changeDataFactory, refControl, this(changeDataFactory, refControl,
notesFactory.create(change)); notesFactory.create(change));
} }
@AssistedInject @AssistedInject
ChangeControl( ChangeControl(
ApprovalsUtil approvalsUtil,
ChangeData.Factory changeDataFactory, ChangeData.Factory changeDataFactory,
@Assisted RefControl refControl, @Assisted RefControl refControl,
@Assisted ChangeNotes notes) { @Assisted ChangeNotes notes) {
this.approvalsUtil = approvalsUtil;
this.changeDataFactory = changeDataFactory; this.changeDataFactory = changeDataFactory;
this.refControl = refControl; this.refControl = refControl;
this.notes = notes; this.notes = notes;
@@ -221,7 +216,7 @@ public class ChangeControl {
if (getCurrentUser().equals(who)) { if (getCurrentUser().equals(who)) {
return this; return this;
} }
return new ChangeControl(approvalsUtil, changeDataFactory, return new ChangeControl(changeDataFactory,
getRefControl().forUser(who), notes); getRefControl().forUser(who), notes);
} }