opendev/gerrit
Code Issues Proposed changes

Merge "Slight optimisation in building dependency lists on change screen"

Browse Source
This commit is contained in:
Edwin Kempin
2012-11-21 00:05:03 -08:00
committed by Gerrit Code Review
parent 75c293a5e9 3b9dafa84b
commit 89af5471ad
1 changed files with 6 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

10
gerrit-gwtui/src/main/java/com/google/gerrit/client/changes/ChangeScreen.java
View File

@@ -314,8 +314,9 @@ public class ChangeScreen extends Screen
boolean depsOpen = false; boolean depsOpen = false;
int outdated = 0; int outdated = 0;
if (!detail.getChange().getStatus().isClosed()) { if (!detail.getChange().getStatus().isClosed()) {
if (detail.getDependsOn() != null) { final List<ChangeInfo> dependsOn = detail.getDependsOn();
for (final ChangeInfo ci : detail.getDependsOn()) { if (dependsOn != null) {
for (final ChangeInfo ci : dependsOn) {
if (!ci.isLatest()) { if (!ci.isLatest()) {
depsOpen = true; depsOpen = true;
outdated++; outdated++;
@@ -325,8 +326,9 @@ public class ChangeScreen extends Screen
} }
} }
} }
if (detail.getNeededBy() != null) { final List<ChangeInfo> neededBy = detail.getNeededBy();
for (final ChangeInfo ci : detail.getNeededBy()) { if (neededBy != null) {
for (final ChangeInfo ci : neededBy) {
if ((ci.getStatus() == Change.Status.NEW) || if ((ci.getStatus() == Change.Status.NEW) ||
(ci.getStatus() == Change.Status.SUBMITTED) || (ci.getStatus() == Change.Status.SUBMITTED) ||
(ci.getStatus() == Change.Status.DRAFT)) { (ci.getStatus() == Change.Status.DRAFT)) {